Powershell script does not run in Java code

Question

I have a simple script and I want to call it from my Java code. The script does not run properly.

The script is very simple: mkdir 0000000;

public static void main(String[] args) throws Exception{
    String path = "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe";
    String command = "C:\\test\\test.ps1";
    Runtime runtime = Runtime.getRuntime();
    Process proc = runtime.exec(path + " " + command);
    proc.destroy();
}

The dir "0000000" is not created. I use JDK 7, windows 10.

Any suggestion would be gratefully appreciated.

Remove proc.destroy();.

Ansgar Wiechers
– Ansgar Wiechers

2019-01-21 20:09:39 +00:00
Commented Jan 21, 2019 at 20:09 — Ansgar Wiechers
– Ansgar Wiechers, Commented Jan 21, 2019 at 20:09
@Ansgar Wiechers: That's not working

Kian
– Kian

2019-01-22 04:21:59 +00:00
Commented Jan 22, 2019 at 4:21 — Kian
– Kian, Commented Jan 22, 2019 at 4:21

Kian · Accepted Answer · 2019-01-22 06:05:56Z

1

I changed the code as below and finally it worked!

    public static void main(String[] args) throws Exception{
        String path = "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe";
        String command1 ="cmd /c \"cd C:\\test && " + path + " /c .\\test.ps1\"";
        Runtime runtime = Runtime.getRuntime();
        Process proc = runtime.exec(command1);
        Thread.sleep(2000);
        proc.destroy();
    }

answered Jan 22, 2019 at 6:05

Kian

2211 gold badge3 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ansgar Wiechers Over a year ago

Using a Thread.sleep(2000) while leaving proc.destroy() in place is setting a hard timeout for the external command, meaning the command will be terminated after 2 seconds, regardless of whether it has finished or not. To wait for the completion of an external command use waitFor() as described in my answer. The change to the commandline (running powershell.exe from CMD instead of running it directly) is not required.

Ansgar Wiechers · Accepted Answer · 2019-01-22 19:03:23Z

1

exec() runs the process asynchronously, so the subsequent proc.destroy() terminates it right away before it can do anything. If you run the program from an interactive shell simply removing proc.destroy() would mitigate the issue, but to actually fix it you need to wait for the external process to finish. You may also want to catch the exception exec() (or waitFor()) could throw.

import java.io.*;

public static void main(String[] args) throws Exception{
    String path = "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe";
    String command = "C:\\test\\test.ps1";
    Runtime runtime = Runtime.getRuntime();
    try {
        Process proc = runtime.exec(path + " " + command);
        proc.waitFor();
    } catch (Exception e) {
        // do exception handling here
    }
}

edited Jan 22, 2019 at 19:03

answered Jan 22, 2019 at 10:25

Ansgar Wiechers

202k27 gold badges286 silver badges363 bronze badges

4 Comments

Kian Over a year ago

Thanks for your answer, but that does not work. destroy() was a part of the problem. The command itself should be changed too.

Ansgar Wiechers Over a year ago

@DanielSmith There was a semicolon missing after the import statement, and I didn't account for the exception waitFor() throws. Both issues are fixed now. The code is tested and does work. Changing the command string is not required.

Kian Over a year ago

Which OS do you use? I use win10 and this does not work on it. proc.waitFor sometimes makes a lot of problems, in my case I prefer the 2 seconds delay.

Ansgar Wiechers Over a year ago

@DanielSmith I ran it on Windows 7 with JDK 8. I just tested it again on Windows 10 with JDK 7. Same result: the code I posted works perfectly fine. It does require the execution policy to actually allow running PowerShell scripts, of course, but if that was the issue, the code from your answer wouldn't work either.

Collectives™ on Stack Overflow

Powershell script does not run in Java code

2 Answers 2

1 Comment

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related