php - quick refactoring

Question

I have 2 methods, that are pretty much exactly the same and I'd likie someone to help me refactor them:

public static function searchFromVideoRequest($word, $returnPropelObjects = false)
{
    $c = new Criteria();
    $c->addJoin(YoutubeVideoPeer::ID,ItemPeer::YOUTUBE_VIDEO_ID);
    $c->addSelectColumn(self::TITLE);
    $c->addSelectColumn(self::ID);
    $c->add(ItemPeer::TITLE, '%'.$word.'%', Criteria::LIKE);
    $c->addAnd(self::YOUTUBE_VIDEO_ID, null, Criteria::ISNOTNULL);
$c->addAscendingOrderByColumn(self::TITLE);
   if ($returnPropelObjects)
          return self::doSelect($c);

        $stmt = self::doSelectStmt($c);
        $results = array();
        while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
          $results[] = $row;
        }
        return $results;
}

public static function searchFromFlickrRequest($word, $returnPropelObjects = false)
{
    $c = new Criteria();
    $c->addJoin(FlickrPhotoPeer::ID,ItemPeer::FLICKR_PHOTO_ID);
    $c->addSelectColumn(self::TITLE);
    $c->addSelectColumn(self::ID);
    $c->add(ItemPeer::TITLE, '%'.$word.'%', Criteria::LIKE);
    $c->addAnd(self::FLICKR_PHOTO_ID, null, Criteria::ISNOTNULL);
    $c->addAscendingOrderByColumn(self::TITLE);
   if ($returnPropelObjects)
          return self::doSelect($c);

        $stmt = self::doSelectStmt($c);
        $results = array();
        while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
          $results[] = $row;
        }
        return $results;
}

Thanks

You mean: you want someone to refactor them for you. Or do you have any specific problem with your attempt at refactoring? If so, show us your attempt and describe in which way it does not work. — Oswald
– Oswald, Commented Mar 25, 2011 at 15:39
I've tried to replace the ` if ($returnPropelObjects) return self::doSelect($c); $stmt = self::doSelectStmt($c); $results = array(); while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) { $results[] = $row; } return $results; } ` into another method and simply call that in both functions, but that hasn't worked — terrid25
– terrid25, Commented Mar 25, 2011 at 15:50

meze · Accepted Answer · 2011-03-25 15:49:47Z

To refactor such methods you can split up them into a few methods that will contain common code and make them private, so no one can use them outside the class:

public static function searchFromVideoRequest($word, $returnPropelObjects = false)
{
    $c = self::buildSearchCriteria($word);
    $c->addJoin(YoutubeVideoPeer::ID,ItemPeer::YOUTUBE_VIDEO_ID);
    $c->addAnd(self::YOUTUBE_VIDEO_ID, null, Criteria::ISNOTNULL);
    return self::getSearchResult($c, $returnPropelObjects);
}

public static function searchFromFlickrRequest($word, $returnPropelObjects = false)
{
    $c = self::buildSearchCriteria($word);
    $c->addJoin(FlickrPhotoPeer::ID,ItemPeer::FLICKR_PHOTO_ID);
    $c->addAnd(self::FLICKR_PHOTO_ID, null, Criteria::ISNOTNULL);
    return self::getSearchResult($c, $returnPropelObjects);
}

private static function buildSearchCriteria($word)
{
    $c = new Criteria();
    $c->addSelectColumn(self::TITLE);
    $c->addSelectColumn(self::ID);
    $c->add(ItemPeer::TITLE, '%'.$word.'%', Criteria::LIKE);
    $c->addAscendingOrderByColumn(self::TITLE);
    return $c;
}

private static function getSearchResult($c, $returnPropelObjects)
{
    if ($returnPropelObjects)
      return self::doSelect($c);

    $stmt = self::doSelectStmt($c);
    $results = array();
    while ($row = $stmt->fetch(PDO::FETCH_ASSOC)) {
      $results[] = $row;
    }
    return $results;
}

PS: And I think the question is OK.

Collectives™ on Stack Overflow

php - quick refactoring

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related