I have some JavaScript code in an HTML page with a button. I have a function called click() that handles the onClick event of the button. The code for the button is as follows:
<input type="button" onClick="click()">button text</input>
The problem is that when the button is clicked, the function is not called. What am I doing wrong here?
Two observations:
You should write
<input type="button" value="button text" />
instead of
<input type="button">button text</input>
You should rename your function. The function click() is already defined on a button (it simulates a click), and gets a higher priority then your method.
Note that there are a couple of suggestions here that are plain wrong, and you shouldn't spend to much time on them:
onclick="javascript:myfunc()". Only use the javascript: prefix inside the href attribute of a hyperlink: <a href="javascript:myfunc()">.onclick="foo()" and onclick="foo();" both work just fine.onclick, onClick and ONCLICK all work. It is common practice to write attributes in lowercase: onclick. note that javascript itself is case sensitive, so if you write document.getElementById("...").onclick = ..., then it must be all lowercase.
$(window).load(function() { ... }). This means that test() is not globally accessible. If you change the dropdown on the left from onLoad to No wrap then your example should work in JSFiddle.click() is a reserved word and already a function, change the name from click() to runclick() it works fine
Check you are calling same function or not.
<script>function greeting(){document.write("hi");}</script>
<input type="button" value="Click Here" onclick="greeting();"/>
Try this
<input type="button" onClick="return click();">button text</input>
I suggest you do:
<input type="button" value="button text" onclick="click()">
Hope this helps you!
<script>
//$(document).ready(function () {
function showcontent() {
document.getElementById("demo22").innerHTML = "Hello World";
}
//});// end of ready function
</script>
I had the same problem where onclick function calls would not work. I had included the function inside the usual "$(document).ready(function(){});" block used to wrap jquery scripts. Commenting this block out solved the problem.
Today this also happened to me. The function name maybe conflicts with keywords. My case is scrape(). I change the function name, everything works fine.
Yes you should change the name of your function. Javascript has reserved methods and onclick = click() is one of them. So just rename it, for example add an 's' to the end.
Try fixing the capitalization. onclick instead of onClick
Reference: Mozilla Developer Docs
onclick and onClick which do similar things to the HTML onclick attribute in other contexts (such as React, XHTML, and DOM) this question uses it as an HTML attribute name which are case-insensitive. I recommend deleting this incorrect answer.
<input type="button" onClick="click();">button text</input>onclick="javascript:click();"