Powershell CSV foreach loop

Question

I had a look at other questions and couldn't find one which helped me with my particular issue, apologies

I have 100+ items in a CSV and I want to put each into two sections of a command. I want this to then be looped through using the following:

$Users = Import-Csv -Path "C:\name\test.csv"       
foreach ($user in $users)
{
    {

       $export = Get-DistributionGroupMember "$user" | Select-Object Identity,Alias,City,Company  | Export-Csv "$user.csv" 
    }
}

What am i looking over?

edit

this is the current output, i'm hoping that the $user would be replaced by each line in the CSV

Where are you defining/setting values for $csv and $title? — Jeff Zeitlin
– Jeff Zeitlin, Commented Feb 6, 2019 at 12:53
@JeffZeitlin - i've updated the code, apologies had copied one I was playing around with — Matthew
– Matthew, Commented Feb 6, 2019 at 12:55
There's no need for the double {{ }} only one pair is needed with foreach. So what exactly is your problem/question, "looking over" doesn't mean much? — henrycarteruk
– henrycarteruk, Commented Feb 6, 2019 at 12:56
What results are you getting, and what results do you expect to get? — Jeff Zeitlin
– Jeff Zeitlin, Commented Feb 6, 2019 at 12:57

henrycarteruk · Accepted Answer · 2019-02-06 13:05:59Z

3

The problem is the double {{ }} you have with the foreach:

Here's a quick demo to show what it's doing:

PS C:\WINDOWS\system32> 1..3 | foreach {Write-Host $_}
1
2
3

PS C:\WINDOWS\system32> 1..3 | foreach {{Write-Host $_}}
Write-Host $_
Write-Host $_
Write-Host $_

answered Feb 6, 2019 at 13:05

henrycarteruk

13.3k2 gold badges40 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jeff Zeitlin Over a year ago

Hmmm... I guess that it does make a difference; I wonder why? I'd gotten the impression that {} was like the same in C/C++/C#, or like BEGIN...END in Pascal.

Ansgar Wiechers Over a year ago

@JeffZeitlin The nested curly brackets define a scriptblock (basically an anonymous function), which doesn't magically invoke itself. What's a bit confusing about PowerShell is that in some cases the curly brackets define begin/end of a nested context (e.g. in foreach loops or try..catch statements) while in other cases they define scriptblocks that are passed as arguments (e.g. with ForEach-Object or Where-Object).

Matthew Over a year ago

@James C - I've done all changes suggested and now seem to have a working script my main issue is that instead of just using the text in the CSV it's adding "@{alias=<text>}" instead of just <text> - any ideas?

Matthew · Accepted Answer · 2019-11-13 17:26:03Z

0

The exact code which resolved the issue:

$Users = Import-Csv -Path "C:\name\test.csv"       
foreach ($user in $users)
{ 

       $export = Get-DistributionGroupMember $user.Alias | Select-Object Identity,Alias,City,Company  | Export-Csv "$User.csv"
}

Thanks

edited Nov 13, 2019 at 17:26

answered Feb 6, 2019 at 14:12

Matthew

1,4602 gold badges20 silver badges36 bronze badges

Collectives™ on Stack Overflow

Powershell CSV foreach loop

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related