How to remove subdocument (by Id) embedded in sub array in MongoDB?

Question

ProductCollection: 
{
  _id: { ObjectId('x1')},
  products: [ 
              { listPrice: '1.90', product: {id: 'xxx1'} },
              { listPrice: '3.90', product: {id: 'xxx2'} },
              { listPrice: '5.90', product: {id: 'xxx3'} }
            ]
},
{
  _id: { ObjectId('x2')},
  products: [ 
              { listPrice: '2.90', product: {id: 'xxx4'} },
              { listPrice: '4.90', product: {id: 'xxx5'} },
              { listPrice: '5.90', product: {id: 'xxx6'} }
            ]
},

I want to remove subdocument (xxx3) from collection (x1), and try below:

ProductCollection.update(
{ 
  "_id": mongoose.Types.ObjectId('x1')  
}, 
{ 
  $pull : { 'products.product': {id: 'xxx3' } } 
}

It just doesn't seem to work. Can anyone please help me? Thank you

It should be { $pull : { 'products': { 'product.id': 'xxx3' } } } — Ashh
– Ashh, Commented Feb 9, 2019 at 7:01
@Winzlet: I tried (seems similar to kmreko advise below, except with quote for 'products'). It gave same result and throws me this error: UnhandledPromiseRejectionWarning: CastError: Cast to ObjectId failed for value "xxx1" at path "product". Next, I tried also: $pull : { 'products': { 'product._id': mongoose.Types.ObjectId('5baa131b36d6a02b442b4b5e') } }. There is no error this time, but nothing happen. The subdocument is still there, anything went wrong here? Thank you — elvin
– elvin, Commented Feb 9, 2019 at 7:52
@Winzlet: Same advise to above, I switch to match to '_id' using this code: $pull : { products: { 'product': { 5baa131b36d6a02b442b4b5e } } }. It works perfectly. Thank you — elvin
– elvin, Commented Feb 9, 2019 at 9:22

kmdreko · Accepted Answer · 2019-02-09 07:00:47Z

6

The field for $pull needs to be the array.

This should work:

$pull: { products: { 'product.id': 'xxx3' } }

answered Feb 9, 2019 at 7:00

kmdreko

65.4k6 gold badges106 silver badges178 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

elvin Over a year ago

I tried, but it throws me this error: UnhandledPromiseRejectionWarning: CastError: Cast to ObjectId failed for value "xxx1" at path "product". Next, I tried also: $pull : { 'products': { 'product._id': mongoose.Types.ObjectId('5baa131b36d6a02b442b4b5e') } }. There is no error this time, but nothing happen. The subdocument is still there, anything went wrong here? Thank you

elvin Over a year ago

I think your advise is correct, and I switch to match to '_id' using this code: $pull : { products: { 'product': { 5baa131b36d6a02b442b4b5e } } }. It works perfectly. Thank you

Ravi Singh · Accepted Answer · 2020-02-10 06:38:36Z

0

add this _id: {id: false} while creating mongoose schema

for eg:

partners:[{
    name: { type: String, default: '' },
    logo: { type: mongoose.Schema.Types.Mixed, default: '' },
    _id: { id: false }
  }],

answered Feb 10, 2020 at 6:38

Ravi Singh

1,1391 gold badge12 silver badges25 bronze badges

Collectives™ on Stack Overflow

How to remove subdocument (by Id) embedded in sub array in MongoDB?

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related