Why does os.system block program execution?

Question

I am trying to create a program to easily handle IT requests, and I have created a program to test if a PC on my network is active from a list.

To do this, I wrote the following code:

self.btn_Ping.clicked.connect(self.ping)

def ping(self):
        hostname = self.listWidget.currentItem().text()
        if hostname:
            os.system("ping " + hostname + " -t")

When I run it my main program freezes and I can't do anything until I close the ping command window. What can I do about this? Is there any other command I can use to try to ping a machine without making my main program freeze?

You can just run the ping command with the -n 1 argument, so that only one attempt is made to contact the remote machine. The -t option you're using is supposed to "Ping the specified host until stopped." as per the documentation, so it's doing exactly what you asked of it. — hyperTrashPanda
– hyperTrashPanda, Commented Feb 11, 2019 at 10:42
You should avoid using os.system. Use subprocess.call(["ping", hostname, "-t"]) instead. — Giacomo Alzetta
– Giacomo Alzetta, Commented Feb 11, 2019 at 11:36
i want it to ping "for ever" or until canceled cause sometimes i am tracking a certain connection problem but i want it to be seperate from the main program — iMBLISH
– iMBLISH, Commented Feb 14, 2019 at 9:00
If you want it to be separate, os.system is wronger. It waits for the command to complete. Don't use os.popen instead. — user24343
– user24343, Commented Feb 14, 2019 at 21:29
actualy i played with threads and made a new thread something like this def ping_t1(host): _thread.start_new_thread(ping_t2,(host, )) — iMBLISH
– iMBLISH, Commented Feb 18, 2019 at 8:59

Tim Pietzcker · Accepted Answer · 2019-02-14 21:11:49Z

6

The docs state that os.system() returns the value returned by the command you called, therefore blocking your program until it exits.

They also state that you should use the subprocess module instead.

edited Feb 14, 2019 at 21:11

answered Feb 11, 2019 at 10:44

Tim Pietzcker

337k59 gold badges520 silver badges572 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

iMBLISH Over a year ago

i try using the subprocess but where do i get the output?

marc_s · Accepted Answer · 2019-02-18 16:02:27Z

As mentioned in Tim Pietzcker's answer, the use of subprocess is highly recommended over os.system (and others).

To separate the new process from your script, use subprocess.Popen. You should get the output printed normally into sys.stdout. If you want something more complex (e.g. for only printing something if something changes), you can set the stdout (and stderr and stdin) arguments:

Valid values are PIPE, DEVNULL, an existing file descriptor (a positive integer), an existing file object, and None. PIPE indicates that a new pipe to the child should be created. DEVNULL indicates that the special file os.devnull will be used. With the default settings of None, no redirection will occur; the child’s file handles will be inherited from the parent.
-- docs on subproces.Popen, if you scroll down

If you want to get the exit code, use myPopenProcess.poll().

Dominique · Accepted Answer · 2019-02-11 11:16:35Z

0

From ping documentation:

ping /?

Options:
-t             Ping the specified host until stopped.
               To see statistics and continue - type Control-Break;
               To stop - type Control-C.

So, by using -t you are waiting until that machine has stopped, and in case that machine is not stopping, your Python script will run forever.

As mentioned by HyperTrashPanda, use another parameter for launching ping, so that it stops after one or some attempts.

answered Feb 11, 2019 at 11:16

Dominique

17.6k20 gold badges81 silver badges161 bronze badges

Collectives™ on Stack Overflow

Why does os.system block program execution?

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related