for loop with multiple conditions not working (JS)

Question

I'm trying to make this loop work in order to get the multiples of 5 that are below 1000 in an array (yeah, just getting started with euler), but it keeps crashing my console:

var multiploCincoArray = []; 

for(i = 1, r = i * 5; r < 1000; i++) {
    multiploCincoArray.push(r);
}
console.log(multiploCincoArray);

I know there's something wrong with the stopping condition but i can't seem to find it.

I know i can do this too:

var multiploCincoArray = []; 

for(i = 1; i <= 199 ; i++) { 
    multiploCincoArray.push(5 * i);
}
console.log(multiploCincoArray);

but i want to follow the path shown in the first script (if possible)...

Nina Scholz · Accepted Answer · 2019-02-13 20:34:44Z

2

You could move the calculation into the conditional part.

var multiploCincoArray = [];
for (var i = 1, r; r = i * 5, r < 1000; i++) {
    multiploCincoArray.push(r);
}

console.log(multiploCincoArray);

answered Feb 13, 2019 at 20:34

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

B. Bach · Accepted Answer · 2019-02-13 20:41:26Z

2

Try that :

var multiploCincoArray = []; 

for(i = 5; i <= 1000; i = i + 5) { 

    multiploCincoArray.push(i);
}
console.log(multiploCincoArray);

edited Feb 13, 2019 at 20:41

answered Feb 13, 2019 at 20:38

B. Bach

213 bronze badges

Comments

Danyal Imran · Accepted Answer · 2019-02-13 20:36:15Z

1

Your approach doesn't seem right imo.

Firstly start with a single variable i, and iterate till 1000.

for (var i=1; i<1000; i++)

check if the i is a multiple of 5 via i%5, if it is then push the value in an array.

var array = [];

for (var i=1; i<1000; i++) {
  if (i%5 === 0) {
    array.push(i);
  }
}

console.log(array);

answered Feb 13, 2019 at 20:36

Danyal Imran

2,60515 silver badges21 bronze badges

2 Comments

Jonas Wilms Over a year ago

This will be five times slower than the approach the OP is trying (if it would be fixed)

Danyal Imran Over a year ago

Just showing how to approach the question, you don't even need the loop to test values, you can simply start with the min possible multiplier and keep adding the multiplier. @JonasWilms

Luca Kiebel · Accepted Answer · 2019-02-13 20:38:28Z

1

 for(i = 1, r = i * 5; r < 1000; i++){

Is the same as:

 i = 1, r = i * 5

 while(r < 1000) i++;

So actually you set r just once (to 5), then you increase i as long as r is smaller than 1000, but as r doesn't change the loop is infinite and crashes your browser.

You might just do:

 for(let i = 5; i < 1000; i += 5)

edited Feb 13, 2019 at 20:38

Luca Kiebel

10.1k7 gold badges34 silver badges47 bronze badges

answered Feb 13, 2019 at 20:35

Jonas Wilms

139k20 gold badges164 silver badges164 bronze badges

1 Comment

sk8mumy Over a year ago

thanks a lot, i couldn't see why r wasn't changing!.

Michel S · Accepted Answer · 2019-02-13 21:28:36Z

0

On the right track but condition in the wrong place. Change for(i = 1, r = i * 5; r < 1000; i++) to for(i = 1, r=5; r < 1000; r=i*5,i++)

Should use let i and let r for scope but I left it out for clarity.

answered Feb 13, 2019 at 21:28

Michel S

11 silver badge5 bronze badges

Collectives™ on Stack Overflow

for loop with multiple conditions not working (JS)

5 Answers 5

Comments

Comments

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related