I have -$2.00 as the string. I am trying to change it to decimal by removing - and $ using substring, but I am doing it wrong. Can someone help me?
Thanks.
-
Wich is the .Net framework version you are using?Guilherme de Jesus Santos– Guilherme de Jesus Santos2011-03-30 17:44:20 +00:00Commented Mar 30, 2011 at 17:44
Add a comment
|
5 Answers
string m = "-$2.00";
decimal d = Math.Abs(Decimal.Parse(m, NumberStyles.Currency));
1 Comment
Buildstarted
Just add
Math.Abs() then and it will be non-negativeSubstring will return a new string. I suspect your issue is likely from trying to mutate the string in place, which does not work.
You can do:
string result = original.Substring(2);
decimal value = decimal.Parse(result);
Depending on how the input string is generated, you may want to use decimal.TryParse instead, or some other routine with better error handling.
Comments
Don't.
Instead, you should make .Net do the dirty work for you:
Decimal value = Decimal.Parse("-$2.00", NumberStyles.Currency);
If, for some reason, you don't want a negative number, call Math.Abs.
Comments
All string operations return a new string, because string is immutable
1 Comment
FreeAsInBeer
While true, I'm not sure how this relates to the OP's question. Was this in response to Reed's answer?
I wouldn't use substring if you can avoid it. It would be much simpler to do something like:
string result = original.Replace("$", "").Replace("-", "");
4 Comments
Tundey
how's this better than using substring? You are creating an extra string object in your sample.
FreeAsInBeer
And how would you propose you do this using
Substring in a more readable fashion while creating no extra objects?FreeAsInBeer
@gtirloni: In this example, and many use cases, that's not a huge deal. Are there other ways of achieving the same result? Sure. Are some of them more efficient? Of course. This is just one of many suggested fixes for the OP's query. Thanks for the feedback though.