Problem using foreach and for loop in PHP

Question

I have 2 kinds of ARRAYS

<?php
    $array1 = array("Car", "House", "Money");
    $array2 = array("John", "Peter", "Mary");

foreach ($array1 as $a1) {
    for($i = 0; $i < count($array2); $i++) {
        if ($a1 === end($array1 )) {
          echo $array2[$i].' has '.$a1.'.<br>';
        }
        else {
          echo $array2[$i].' has '.$a1.',<br>';
        }
    }
}
?>

But the output is like this

John has Car,
Peter has Car,
Mary has Car,
John has House,
Peter has House,
Mary has House,
John has Money.
Peter has Money.
Mary has Money.

What I want is like this

John has Car,
Peter has House, 
Mary has Money.

is there any other way?

except for calling the specific value of an array like this

$array1[0]."has ".$array2[0].",<br>"
$array1[1]." has ".$array2[1].",<br>" 
$array1[2]." has ".$array2[2].".<br>"

if I need to use "break;" where should I put it?

TIA

No. The data in the DB will be stored in the array1 but the data in the array2 is fixed — Jerick Arcega
– Jerick Arcega, Commented Mar 12, 2019 at 7:35

Subhash Patel · Accepted Answer · 2019-03-12 08:42:08Z

5

Please check my answer helpful for you.

<?php
    $array1 = array("Car", "House", "Money");
    $array2 = array("John", "Peter", "Mary");

for($i = 0; $i < count($array2); $i++) {

          echo $array2[$i].' has '.$array1[$i].'.<br>';

    }

?>

and output as below:

John has Car. Peter has House. Mary has Money.

answered Mar 12, 2019 at 8:42

Subhash Patel

6747 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jeto · Accepted Answer · 2019-03-12 12:04:39Z

2

You don't need to loop twice. You can simply iterate over the list of people and use the given key to access the corresponding object:

$objects = ['Car', 'House', 'Money'];
$people = ['John', 'Peter', 'Mary'];

foreach ($people as $i => $person) {
  echo $i > 1 ? ' and ' : '', $person, ' has ', $objects[$i];
}

Demo: https://3v4l.org/Fa45t

Note that this assumes the two arrays have the same size. You can use array_key_exists (or isset in this case) to make sure, otherwise.

Updated after your edit. This handles the case where there are more people than objects:

$objects = ['Car', 'House', 'Money'];
$people = ['John', 'Peter', 'Mary', 'Paul'];

foreach ($people as $i => $person) {
  if (!array_key_exists($i, $objects)) {
    break;
  }
  echo ($i > 0 ? ',<br>' : ''), $person, ' has ', $objects[$i];
}

Demo: https://3v4l.org/Hd3e0

edited Mar 12, 2019 at 12:04

answered Mar 12, 2019 at 7:35

Jeto

15k2 gold badges39 silver badges50 bronze badges

3 Comments

Jerick Arcega Over a year ago

I did some changes. What if the element of the array is not fixed to 3? Thank you for your answer. I'm currently trying to fixed your code to my code to see if it works.

Jerick Arcega Over a year ago

after tweaking your code to fit mine. it finally worked!. Thank you

Jeto Over a year ago

@JerickArcega No problem. I've just updated my answer with a working example where there are more objects than people.

Nick · Accepted Answer · 2019-03-12 09:13:15Z

2

You can simplify your loop as you want to iterate through both arrays at the same time. So, assuming $array1 and $array2 have the same number of values, you can use something like this. By comparing the index with the number of elements in the array we decide whether to output "while", "and" or nothing after each phrase.

foreach ($array2 as $key => $value) {
    if (!isset($array1[$key])) continue;
    echo "$value has $array1[$key]";
    echo $key < count($array2) - 2 ? " while " : ($key < count($array2) - 1 ? " and " : "");
}

Output:

John has Car while Peter has House and Mary has Money

Update

Based on OPs edits, the code can be simplified to this, which includes a check that a corresponding object exists for each person (the code above has been similarly edited):

foreach ($array2 as $key => $value) {
    if (isset($array1[$key])) echo "$value has $array1[$key]";
}

Demo on 3v4l.org

edited Mar 12, 2019 at 9:13

answered Mar 12, 2019 at 7:35

Nick

147k23 gold badges67 silver badges106 bronze badges

2 Comments

Jerick Arcega Over a year ago

I did some changes. What if the element of the array is not fixed to 3? Thank you for your answer. I'm currently trying to fixed your code to my code to see if it works

Nick Over a year ago

@JerickArcega I've made changes to cope with the situation where there might be more people than objects. But I'm glad to see you've already got Jeto's answer to work for you.

Passionate Coder · Accepted Answer · 2019-03-12 07:47:58Z

1

You can also below solution

$output_string = '';
 for($i = 0; $i < count($array1); $i++) {
    for($j = 0; $j < count($array2); $j++) {
        if($i == $j){
            $output_string .=  $array2[$i]." has ".$array1[$i];
        }
    }
    if(!empty($output_string)){
        if($i == 0){
            $output_string .= " while  ";
        }else{
            if($i<(count($array1) -1)){
                $output_string .= " and  ";
            }            
        }             
    }
}
echo $output_string;

answered Mar 12, 2019 at 7:47

Passionate Coder

7,3042 gold badges24 silver badges50 bronze badges

1 Comment

Jerick Arcega Over a year ago

I did some changes. Thank you for your answer. I'm currently trying to fixed your code to my code to see if it works

Andreas · Accepted Answer · 2019-03-12 07:57:21Z

0

Drop the for loop inside your foreach loop like this:

foreach ($array1 as $key => $a1) {
  echo ($key === 1 ? " while " : ($key > 1 ? " and " : "")) . "$array2[$key] has $a1";
}

edited Mar 12, 2019 at 7:57

Andreas

24k7 gold badges34 silver badges75 bronze badges

answered Mar 12, 2019 at 7:56

Sarah Dominguez Perea

4082 silver badges9 bronze badges

1 Comment

Nick Over a year ago

This is pretty much an exact copy of @Jeto answer.

Collectives™ on Stack Overflow

Problem using foreach and for loop in PHP

5 Answers 5

Comments

3 Comments

2 Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

3 Comments

2 Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related