How to add a html <a> tag with javascript or jquery?

Question

I've done a slideshow for news on a website which works with jquery. Everything works perfectly except for a line where I try to add a link which links the complete version of the news. But Javascript never adds the tag nor show an error on the console. Here's the function which changes the currently displayed news on the slideshow :

function changeNews(newCurrentNewsNumber)
    {
        var realNewsNumber = newCurrentNewsNumber - 1;
        $("#number" + currentNewsNumber).css("color", "#FFFFFF");
        $("#number" + currentNewsNumber).css("backgroundColor", "#474747");
        $("#imageNews").attr("src").replace(newsImagePathArray[newCurrentNewsNumber - 1]);
        $("#number" + newCurrentNewsNumber).css("color", "#055c94");
        $("#number" + newCurrentNewsNumber).css("backgroundColor", "#FFFFFF");
        $("#textNews").html(newsTitleArray[realNewsNumber]+"<br />" + newsTextArray[realNewsNumber]+"<br />");
        $("#textNews").append("<a href=\"index.php?corps=news&id="+realNewsNumber+">Voir la suite de la news...</a>");
        currentNewsNumber = newCurrentNewsNumber;
    }

newCurrentNewsNumber is the new news to display. currentNewsNumber is the old one. newsXXXArray contains elements of the news. The line in blod is the one which doesn't do what it should. Any help would appreciated.

Guidhouse · Accepted Answer · 2011-04-02 23:00:58Z

2

Simply:

$("#textNews").append("<a href=\"index.php?corps=news&id="+realNewsNumber+"\">Voir la suite de la news...</a>");

You just forgot to add an escaped " after '+realNewsNumber+"' The devil is in the details

edited Apr 2, 2011 at 23:00

answered Apr 2, 2011 at 22:53

Guidhouse

1,43611 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Guidhouse Over a year ago

I think i found your real problem. Pls check again

Loïc Lopes Over a year ago

Thanks, It works. What a stupid error ! I suppose it's the kind of problems you have when you work at 01:00am.

Guidhouse Over a year ago

Lol.. been there myself. btw. pls mark as answer if it helped:)

jbrookover Over a year ago

My original solution left out the escaped closing quote (though I edited back in). Perhaps jQuery is smart enough to handle it?

Guidhouse Over a year ago

Maybe JSFiddle is smart enough?

jbrookover · Accepted Answer · 2011-04-02 23:03:29Z

0

This works fine for me in JSFiddle:

function changeNews(newCurrentNewsNumber) {

    var realNewsNumber = newCurrentNewsNumber - 1;
    $("#textNews").html("Test Title"+"<br />" + "Text Text" +"<br />");
    $("#textNews").append("<a href=\"http://www.google.com?corps=news&id="+realNewsNumber+"\">Voir la suite de la news...</a>");
}

$(function() { changeNews(1); });

The only thing I can think of is you're trying to append the code before the DOM is completely loaded?

answered Apr 2, 2011 at 23:03

jbrookover

5,1501 gold badge25 silver badges23 bronze badges

Collectives™ on Stack Overflow

How to add a html <a> tag with javascript or jquery?

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related