Modify object in for loop (async/await)

Question

exports.allUsers = async (req, res, next) => {
  try {
    let users = await User.find({})

    console.log(users)
    // [{ role: 'user',
    //   skills: [...],
    //   email: '[email protected]',
    //   education: [],
    //   createdAt: 2019-04-02T11:17:33.979Z
    // },
    // { role: 'admin',
    //   skills: [...],
    //   email: '[email protected]',
    //   education: [],
    //   createdAt: 2019-04-02T11:17:33.979Z
    // } ]

    for (let i = 0; i < users.length; i++) {
      users[i].bluepages = await bluepagesApi.bluepagesMail(users[i].email)
      users[i].image = await bluepagesApi.profileimage(users[i].email)

      console.log(users[i].bluepages)
      // { 
      //   job: 'Developer',
      //   givenname: 'Tony',
      //   ismanager: 'N',
      //   employeetype: 'P'
      // }
      // { 
      //   job: 'Job Title',
      //   givenname: 'Max',
      //   ismanager: 'N',
      //   employeetype: 'P'
      // }
    }

    console.log(users)
    // [{ role: 'user',
    //   skills: [...],
    //   email: '[email protected]',
    //   education: [],
    //   createdAt: 2019-04-02T11:17:33.979Z
    // },
    // { role: 'admin',
    //   skills: [...],
    //   email: '[email protected]',
    //   education: [],
    //   createdAt: 2019-04-02T11:17:33.979Z
    // } ]

    return res.json({
      users: users
    })
  } catch (error) {
    next(error)
  }
}

If I do a console.log(users[i].bluepages) inside my for-loopthe data that is fetched via an API is shown but if I do a console.log(users[i]) in my for-loop the new object is not shown.

Also outside/after my for-loop the changes are not visible.

I also tried to do it with Array.map without any success.

Node.js logs from my terminal: https://pastebin.com/w7c50YRt

Do the two methods actually return promises? Also how do you log? Could you show the code with the logs and its output? — Jonas Wilms
– Jonas Wilms, Commented Apr 2, 2019 at 12:09
I added all console logs and the returned data in my question @JonasWilms — mrks
– mrks, Commented Apr 2, 2019 at 12:19
The for-loop executes correctly and the json is sent when the loop has finished. — mrks
– mrks, Commented Apr 2, 2019 at 12:20
Can you print the value of i along with the data? Try using for...of loop. — ssakash
– ssakash, Commented Apr 2, 2019 at 12:30

Jonas Wilms · Accepted Answer · 2019-04-02 12:49:59Z

3

Mongoose tricks you out. It adds a toJSON() and a toString() method to documents, that only shows the properties defined in the Model. If you log it to the console, toString will be called, if you send it as json toJSON() will be called.

console.log(
  users[0], // looks as if bluepages does not exist
  users[0].bluepages // but it does actually
);

To let the users behave as objects, map them to regular objects:

let users = (await User.find({})).map(u => u.toObject());

answered Apr 2, 2019 at 12:49

Jonas Wilms

139k20 gold badges164 silver badges164 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ali Ebrahimi · Accepted Answer · 2019-04-02 12:55:37Z

1

mongoose acts according to definition of user schema. you should add bluepages and image keys to schema of User

answered Apr 2, 2019 at 12:55

Ali Ebrahimi

992 bronze badges

Collectives™ on Stack Overflow

Modify object in for loop (async/await)

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related