Using self.xxxx as a default parameter for recursive function - Python

Question

I'm trying to simplify my work and fine-tune the code. What I'm working with is a binary search tree. Right now I have a function in my Tree() class that finds all the elements and puts them into a list.

tree = Tree()
#insert a bunch of items into tree

then I use my makeList() function to take all the nodes from the tree and puts them in a list. To call the makeList() function, I do tree.makeList(tree.root). To me this seems a little repetitive. I'm already calling the tree object with tree.so the tree.root is just a waste of a little typing.

Right now the makeList function is:

    def makeList(self, aNode):
        if aNode is None:
            return []
        return [aNode.data] + self.makeList(aNode.lChild) + self.makeList(aNode.rChild)

I would like to make the aNode input a default parameter such as aNode = self.root (which does not work) that way I could run the function with this, tree.makeList().

First question: why doesn't that work?
Second question: is there a way that it can work (for this kind of recursive function)? As you can see the makeList() function is recursive so I cannot unconditionally initialize as any constant value at the beginning of the function or else I get an infinite loop.

EDIT Here is all the code as requested:

class Node(object):
    def __init__(self, data):
        self.data = data
        self.lChild = None
        self.rChild = None

class Tree(object):
    def __init__(self):
        self.root = None

    def __str__(self):
        current = self.root

    def isEmpty(self):
        if self.root == None:
            return True
        else:
            return False

    def insert (self, item):
        newNode = Node (item)
        current = self.root
        parent = self.root

        if self.root == None:
            self.root = newNode
        else:
            while current != None:
                parent = current
                if item < current.data:
                    current = current.lChild
                else:
                    current = current.rChild

            if item < parent.data:
                parent.lChild = newNode
            else:
                parent.rChild = newNode

    def inOrder(self, aNode):
        if aNode != None:
            self.inOrder(aNode.lChild)
            print aNode.data
            self.inOrder(aNode.rChild)

    def makeList(self, aNode):
        if aNode is None:
            return []
        return [aNode.data] + self.makeList(aNode.lChild) + self.makeList(aNode.rChild)


    def isSimilar(self, n, m):
        nList = self.makeList(n.root)
        mList = self.makeList(m.root) 
        print mList == nList

What do you want with 'self' within a module level method? This makes absolutely no seense. If makeList2() is a method of class then please provide correct code and not snippets without context. — user2665694
– user2665694, Commented Apr 5, 2011 at 16:53
How does this make no sense? I'm trying to use my makeList() function simpler by using a default parameter for the root of the tree instead of having to call it. — chrisheinze
– chrisheinze, Commented Apr 5, 2011 at 18:40
I agree with @crh878 that this makes sense. I tried it myself, also for creating a binary search tree. No joke... — william_grisaitis
– william_grisaitis, Commented Apr 24, 2014 at 1:54

Community · Accepted Answer · 2017-05-23 12:02:02Z

68

larsmans answered your first question

For your second question, can you simply look before you leap to avoid recursion?

def makeList(self, aNode=None):
    if aNode is None:
        aNode = self.root
    treeaslist = [aNode.data]
    if aNode.lChild:
        treeaslist.extend(self.makeList(aNode.lChild))
    if aNode.rChild:
        treeaslist.extend(self.makeList(aNode.rChild))
    return treeaslist

edited May 23, 2017 at 12:02

CommunityBot

11 silver badge

answered Apr 6, 2011 at 4:00

nofinator

3,05323 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fred Foo · Accepted Answer · 2011-04-05 17:04:56Z

64

It doesn't work because default arguments are evaluated at function definition time, not at call time:

def f(lst = []):
    lst.append(1)
    return lst

print(f()) # prints [1]
print(f()) # prints [1, 1]

The common strategy is to use a None default parameter. If None is a valid value, use a singleton sentinel:

NOTHING = object()

def f(arg = NOTHING):
    if arg is NOTHING:
        # no argument
    # etc.

edited Apr 5, 2011 at 17:04

answered Apr 5, 2011 at 16:52

Fred Foo

365k80 gold badges765 silver badges852 bronze badges

9 Comments

user395760 Over a year ago

You can omit the Sentinel. Just use NOTHING = object(). Guaranteed to yield a unique singleton you can check for via is.

Glenn Maynard Over a year ago

I'd strongly advise against making foo(1, None) and foo(1) do different things.

Fred Foo Over a year ago

@Glenn: with a one-arg function that must deal with arbitrary objects, it can make sense sometimes.

chrisheinze Over a year ago

Ok, I understand why it doesn't work and also how your first code segment continually appends whatever value you add but I'm not fully following what's going on in the second code segment.

Fred Foo Over a year ago

@crh878: the point about using None is the most important. The second part constructs an object NOTHING, uses that as the default argument and checks whether that exact object was passed in. If you hide NOTHING (don't export it from your module), it cannot be passed in by client code. is compares objects by memory address.

|

mattmess1221 · Accepted Answer · 2021-07-15 15:33:11Z

2

If you want to treat None as a valid argument, you could use a **kwarg parameter.

def function(arg1, arg2, **kwargs):
    kwargs.setdefault('arg3', default)
    arg3 = kwargs['arg3']
    
    # Continue with function

function("amazing", "fantastic") # uses default
function("foo", "bar", arg3=None) # Not default, but None
function("hello", "world", arg3="!!!")

I have also seen ... or some other singleton be used like this.

def function(arg1, arg2=...):
    if arg2 is ...:
        arg2 = default

edited Jul 15, 2021 at 15:33

answered Mar 12, 2019 at 19:24

mattmess1221

4,5942 gold badges26 silver badges20 bronze badges

Collectives™ on Stack Overflow

Using self.xxxx as a default parameter for recursive function - Python

3 Answers 3

Comments

9 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

9 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related