.Net core Dependency injection - with parameters

Question

NOTE: This example has been simplified

I have got a Client's Contact table and wanted to retrieve specific client contact information from DB. The code I typed belove brings me all contact details. I wanted to use a parameter to only bring me specific client contacts.

I used IClientContactRepository interface like this

public interface IClientContactRepository
{
    IQueryable<ClientContactModel> ClientContacts { get; }
}

And i used this class to retrive data from database with dapper

public class ClientContactRepository : IClientContactRepository
{
    private readonly IConfiguration configuration;
    private List<ClientContactModel> ClientContactList {get;set;}


    public ClientContactRepository(IConfiguration config)
    {
        configuration = config;

        SqlConnection conn = new SqlConnection(configuration["ConnectionString"]);

        using (var connection = conn)
        {
            ClientContactList = connection.Query<ClientContactModel>("Select * FROM ContactTable ").ToList();
        }
    }
    public IQueryable<ClientContactModel> ClientContacts => ClientContactList;
}

In my Startup class

  services.AddTransient<IClientContactRepository, ClientContactRepository>();

My QUESTION is: can I pass the client's id parameter to the constructor.

I tried this: add a parameter to the constructor

  public ClientContactRepository(IConfiguration config, int clientId)

and tried to start up class.

 services.AddTransient<IClientContactRepository, ClientContactRepository(int,i)>()

Didn't work.... Can someone help me how to pass parameter please?

Repository pattern is typically implemented using a method to find what it needs to. Thus instantiating the list in the constructor is not the way to go. You should hit the database at the point you need to get the data. The calling client code will know what code to search for. It isn't the responsibility of your IoC container to provide those properties. — Andez
– Andez, Commented Apr 7, 2019 at 16:24

Moho · Accepted Answer · 2019-04-07 16:39:12Z

Yes, but where are you getting the client ID from - is it a configured value that will be static for the lifetime of the application? If so, you can use the AddTansient method overload that accepts a factory delegate to create the objects.

The better way (will cover all use cases) is registering the type that can provide that information (create one if no such type exists) with the DI container and use that as a parameter in the constructor of your repo.

As an example, let’s say you get your client ID from a claim, so the type you need to inject is IPrincipal:

services.AddScoped<IPrincipal>(
    provider => provider.GetService<IHttpContextAccessor>()
        .HttpContext
        .User);

You would then inject the IPrincipal into your repo constructor and retrieve the client ID. An even better way would be to create your own type “ClientIdAccessor” which is responsible for providing the client ID. You would then not have a dependency on IPrincipal when testing your repo and the implementation of this new type would only depend on external libraries for your asp.net core implementation.

Side note: are you certain you want to use AddTransient for your repo? Usually you’d want to use the same repo object for the lifetime of the request (I.e. AddScoped).

imady · Accepted Answer · 2024-10-03 22:57:03Z

0

This works in my MAUI project:

//Registration:
mauiAppBuilder
            .Services
            .AddTransient<Func<ObservableCollection<ImadyMailDTO>, MenuMailPage>>
            (serviceProvider => models =>
                {
                    return new MenuMailPage(models);
                });


//Use DI to request the instance of MenuMailPage
this.menuMailPage = _serviceProvider
.GetRequiredService<Func<ObservableCollection<ImadyMailDTO>, 
MenuMailPage>>()(menuMailList);
Navigation.PushAsync(menuMailPage);

edited Oct 3, 2024 at 22:57

answered Oct 3, 2024 at 22:51

imady

6901 gold badge6 silver badges8 bronze badges

Collectives™ on Stack Overflow

.Net core Dependency injection - with parameters

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related