Function Contain Specific String Return a string

Question

Hi I am new to javascript I am trying to create a function that I wanted to call if the string contains (-) will return a string value of "00" but if not will remain the same value. I will really appreciate any help or advice thank you.

example
val1= -01
expected output is =00


val2= 03
expected output:03

Code but not working

I used it like

myFunction(val1);

but this still return same value even string contains this -

function myFunction(myFunction) {

  var n = myFunction.includes("-");
  if (n =="true"){
      return "00:00";
  }else{
      return myFunction;
  }

Oliver Dunk · Accepted Answer · 2019-04-07 17:10:17Z

2

It looks like you're checking if the result of calling includes is equal to the string "true", which won't be the case. Simply replacing your if statement with if(n) should do the trick.

answered Apr 7, 2019 at 17:10

Oliver Dunk

5345 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Harun Or Rashid · Accepted Answer · 2019-04-07 17:19:54Z

0

Use Array.prototype.includes() as below:

var val1= '-01';
var val2= '03';

function myFunction(s){
    return s.includes('-') ? '00' : s;
}

console.log(myFunction(val1));
console.log(myFunction(val2));

answered Apr 7, 2019 at 17:19

Harun Or Rashid

5,9572 gold badges21 silver badges23 bronze badges

Comments

paulsm4 · Accepted Answer · 2019-04-07 17:11:55Z

0

There are several problems here.

Try this:

function myFunction(myString) {

  if (myString.includes("-")) {
      return "00:00";
  }else{
      return myString;
  }

Use different names for the function ("myFunction") and the function parameter ("myString").
Use the keyword "true", instead of the string "true". Or even better, just use a boolean expression.

answered Apr 7, 2019 at 17:11

paulsm4

123k23 gold badges175 silver badges245 bronze badges

Comments

BlackPearl · Accepted Answer · 2019-04-07 17:14:21Z

0

Make sure you have proper names for your functions and variables. Further, boolean checks can be simplified directly. Try this

function myFunction(str) {
   if (str.includes("-")) {
     return "00";
   } else {
     return str;
   }
}

An other way would be to use the ternary operator.

function myFunction(str) {
    return str.includes("-") ? "00" : str
}

answered Apr 7, 2019 at 17:14

BlackPearl

1,6721 gold badge10 silver badges16 bronze badges

Comments

mbojko · Accepted Answer · 2019-04-07 17:15:44Z

0

function myFunction(word) {

  if (word.includes("-")) {
    return "00";
  }

  else {
    return word;
  }
}

console.log(myFunction("-01"));
console.log(myFunction("02"));

Don't use myFunction as both the name of a function and its argument. It's a Bad Idea.

edited Apr 7, 2019 at 17:15

answered Apr 7, 2019 at 17:10

mbojko

14.8k2 gold badges21 silver badges28 bronze badges

1 Comment

t.niese Over a year ago

You suggest to not use myFunction as the name for the function and the argument, but you do not explain why the code really failing. Because the naming might be a bad idea but does not explain why it is failing.

ferhatelmas · Accepted Answer · 2019-08-19 20:47:06Z

-1

function mycontain(s) {
  // check if desired token exists then return special or original
  return s.includes('-') ? '00' : s
}

edited Aug 19, 2019 at 20:47

answered Apr 7, 2019 at 17:14

ferhatelmas

3,9981 gold badge24 silver badges26 bronze badges

Collectives™ on Stack Overflow

Function Contain Specific String Return a string

6 Answers 6

Comments

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related