Get variable from object method in javascript

Question

I'm new to objects in javascript and I'm having some problems with the following code.

var Color = function(color){
   this.color = color;
   this.getCode = function(){
      var colorHex;
      var colorRBG;
      switch(color){
          case "White":
              colorHex = "#ffffff";
              colorRGB = "255,255,255";
              break;
          case "Black":
              colorHex = "#000000";
              colorRGB = "0,0,0";
              break;
          default:
              return false;
      }
      return {
          colorHex: colorHex,
          colorRGB: colorRGB
      }
   }
}

What I want to do is get the colorHex value like this but it isn't working:

var newColor = new Color("White");
alert(newColor.getCode().colorHex);

What am I doing wrong?

This is a simplified version of my actual application. Maybe I've another bug somewhere because I keep getting an "undefined" value in my app. — elclanrs
– elclanrs, Commented Apr 5, 2011 at 18:54

beatgammit · Accepted Answer · 2011-04-05 18:51:25Z

1

You need to use this.color instead of color in your switch statement. Color would be undefined here and the default case would be called.

Color (the parameter) is no longer in scope, so you need to access the member variable. Javascript does not automatically prepend this like other languages do, you have to do it manually.

answered Apr 5, 2011 at 18:51

beatgammit

20.3k20 gold badges91 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

elclanrs Over a year ago

I tried that but I keep getting "undefined"... I'll post the code below.

beatgammit Over a year ago

Really?? You could try: newColor.getCode.call(newColor) to hack it. Changing switch(color) to switch(this.color) should work though...

elclanrs Over a year ago

I just got it! I was passing a value of "colro" instead of "color" to the function that's why. I didn't see it and this was driving me crazy. BTW, it works fine with just "color" in the switch statement.

Billy Moon · Accepted Answer · 2011-04-05 18:51:21Z

1

you need to switch(this.color)

answered Apr 5, 2011 at 18:51

Billy Moon

58.9k27 gold badges148 silver badges244 bronze badges

Collectives™ on Stack Overflow

Get variable from object method in javascript

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related