Password Validation without multiple if-else

Question

I have the following code for Password Validation to test different cases and add valid and invalid classes to show the correctness in my HTML file.But I have a lot of if-else blocks to verify all the conditions. I tried implementing with switch statement but not luck. Any leads on how this can be implemented with a lot of if-else conditions. Thanks!

var pwdCheck = (str) => {
  var upper = /[A-Z]/g,
    numbers = /[0-9]/g,
    lower = /[a-z]/g;
  if (str.match(upper)) {
    uppercase.classList.remove("invalid");
    uppercase.classList.add("valid");
  } else {
    uppercase.classList.remove("valid");
    uppercase.classList.add("invalid");
  }
  // Numbers //
  if (str.match(numbers)) {
    numeric.classList.remove("invalid");
    numeric.classList.add("valid");
  } else {
    numeric.classList.remove("valid");
    numeric.classList.add("invalid");
  }
}

Validation block first, store the result in a variable, then a single block that sets classes based on the result of the validation. — Wiktor Zychla
– Wiktor Zychla, Commented Apr 12, 2019 at 9:41

Prasad Telkikar · Accepted Answer · 2019-04-12 09:42:10Z

2

Why can't you use && operator to combine two different conditions to minimize if.. else ladder to single if else

var pwdCheck = (str) => {
  var upper = /[A-Z]/g,
    numbers = /[0-9]/g,
    lower = /[a-z]/g;

  //Here you can use multiple conditions to check your password. I used && to combine two conditions
  if (str.match(upper) && str.match(numbers)) {
    uppercase.classList.remove("invalid");
    uppercase.classList.add("valid");
  } else {
    uppercase.classList.remove("valid");
    uppercase.classList.add("invalid");
  }
}

answered Apr 12, 2019 at 9:42

Prasad Telkikar

16.1k7 gold badges26 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Tapan Dave · Accepted Answer · 2019-04-12 09:44:59Z

1

you can use ternary operator str.match(upper) ? true : false, that can reduce your code and improves readability and store let removeClass = uppercase.classList.remove("invalid"); as local variable

answered Apr 12, 2019 at 9:44

Tapan Dave

2831 gold badge4 silver badges17 bronze badges

Collectives™ on Stack Overflow

Password Validation without multiple if-else

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related