Embedding javascript in php pages [duplicate]

Question

I am trying to embed some JavaScript into a php page with the intention of getting Jquery to work. The php is in a wordpress site. This will eventually form the basis of a plugin. I have used <script> tags to embed a call to an alert function, which does work well. Problem is if I try to add some jquery code e.g $(document).ready(function(){}); it doesn't work, any consequent alerts don't work, no errors or anything!

I've tried googling the problem and there's loads of advice but nothing is working

echo "<script>alert('This works')</script>"

echo "<script>
$(document).ready(function(){

alert('But this doesn't');});
</script>"

The first alert appears fine, but the second doesn't.

in php page, it will as its working in html pages <script>alert(1)</script> — devpro
– devpro, Commented Apr 12, 2019 at 14:39
Double quoted strings are parsed in PHP. It this case PHP is trying to replace jQuery $ to PHP variable. Change to single quoted string. — WebHQ
– WebHQ, Commented Apr 12, 2019 at 14:42
@WebHQ: agreed , and he also having issue with first alert as he is not terminating. — devpro
– devpro, Commented Apr 12, 2019 at 15:01

devpro · Accepted Answer · 2019-04-12 15:05:10Z

1

In your code, you have 2 issues, first of all, you are not terminating your first alert:

echo "alert('This works')"

you must need to terminate with ; otherwise it will give you javascript error.

Second, in your second alert you have quotation issue, you are using single quote inside a single quotes.:

alert('But this doesn't'); // remove single quotation from here.

I tried this and its working fine:

echo "alert('This works');"; // terminate the first line
echo "$(document).ready(function(){
alert('But this does not'); 
});";

edited Apr 12, 2019 at 15:05

answered Apr 12, 2019 at 14:58

devpro

16.1k3 gold badges29 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

miken32 Over a year ago

JS doesn't need semicolons

devpro Over a year ago

@Miken32 u r right but u echo both together u will get an error in console plz try

WebHQ · Accepted Answer · 2019-04-12 16:13:18Z

0

This is really bad codding. You should separate logic and view layers into script and template files.

But if you have no other option try Heredoc strings:

echo <<<EOT
<script>
    $(function() {
        alert("this will work with > ' < char included");
        alert('this will work with > \' < char included');
        alert('this will work with');
        alert("this will work with");
    });
</script>
EOT;

edited Apr 12, 2019 at 16:13

answered Apr 12, 2019 at 16:04

WebHQ

7218 silver badges21 bronze badges

Collectives™ on Stack Overflow

Embedding javascript in php pages [duplicate]

2 Answers 2

2 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Linked

Related