Unity3D C# private variable will not update with public setter function

Question

Minimal code from BoardScript.cs

public class BoardScript : MonoBehaviour {
    private float angle;
    private static BoardScript instance;

    void Awake() {
        if (instance == null) {
            instance = this;
        }
        else if (instance != this) {
            Destroy(gameObject);
        }
     }

    Start(){
        angle = 0.5f;
    }

    Update(){
        Debug.Log("angle = " + angle); // logged angle never changes.
        Debug.Log("GetAngle() returns " + GetAngle()); // also never changes...
     }

    public SetAngle(float arg) {
        angle = arg;
        Debug.Log("angle set to " + angle);
        // Above always logs new angle as called fron Settings.cs. 
    }

    private float GetAngle() { // only use is for debugging this issue.
        Debug.Log("angle is " + angle); // Does not log newly set angle.
        return angle;
    }
}

Minimal code Settings.cs

private GameObject theBoard;

public void SetBoardAngule(float arg) {
    theBoard.GetComponent<BoardScript>().SetAngle(arg);
    Debug.Log("Settings - SetAngle to " + arg); // Logs correct angle.
}

The update function logs "angle = 0.5" no matter what it gets set to in method SetAngle(). This seems terribly simple to me. What am I doing incorrectly?

Are you sure, that you are calling GetAngle on the same instance, that you are calling SetAngle on? You should share the code, where you call SetAngle, too — Ali Baba
– Ali Baba, Commented Apr 13, 2019 at 0:00
Instead of theBoard.GetComponent<BoardScript>().SetAngle(arg); try BoardScript.instance.SetAngle(arg) — Ali Baba
– Ali Baba, Commented Apr 13, 2019 at 0:20
@RigidBody won't compile because your instance is private. The singleton should be public for access though. — knh190
– knh190, Commented Apr 13, 2019 at 0:51

Hassan Faghihi · Accepted Answer · 2019-04-13 13:21:42Z

First thing first: your getter setter is all good.

other stuff: first thing if you are coming from Java world, you do not need to create functions for getter setters:

public SetAngle(float arg) {
        angle = arg;
        Debug.Log("angle set to " + angle);
        // Above always logs new angle as called fron Settings.cs. 
    }

    private float GetAngle() { // only use is for debugging this issue.
        Debug.Log("angle is " + angle); // Does not log newly set angle.
        return angle;
    }

can be converted to:

public float Angle
{
    get{return _angle;}
    set{_angle = value;}
}

second, i'm not sure why you do destroy the object, without creating one on awake: but here what you do is, if object doesn't exist, create one, .... otherwise if object exist, destroy current, but not creating another one.

third: which also relate to second: we are creating singleton, to have only one instance of our class, if that's what you want, there are tons of way to do it, but you have to set your variable accordingly: currently you are setting the value on (this instance) which may change from the (stored instance), and once that happen, you loss pointers, and you have to call it on the singleton class:

public float Angle
{
    get{return BoardScript.instance._angle;}
    set{BoardScript.instance._angle = value;}
}

instead of:

public float Angle
{
    get{return this._angle;}
    set{this._angle = value;}
}

forth: which again is related to second: at first your object instance will be stored inside instance variable, but if you creating another object which call awake (i'm forgotten how awake worked and got invoked) that object will cause current object to get disposed, i'm not sure if this is the behaviour that you want, just saying...

void Awake() {
    if (instance == null) {
        instance = this;
    }
    else if (instance != this) {
        Destroy(gameObject);
    }
 }

RigidBody · Accepted Answer · 2019-04-13 12:55:35Z

0

As pointed out by commentators, change

private static BoardScript instance;

to

public BoardScript instance;

answered Apr 13, 2019 at 12:55

RigidBody

6743 gold badges12 silver badges29 bronze badges

Collectives™ on Stack Overflow

Unity3D C# private variable will not update with public setter function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related