Laravel API ErrorException: Undefined variable:

Question

I'm trying to start out with this laravel API for CRUD. So far show and delete works (I'm using postman & json script) but somehow when i try to do a post request I get this error:


ErrorException: Undefined variable: requests in file C:\xampp\htdocs\psdsystems\app\Http\Controllers\CustomerController.php on line 35
Stack trace:
  1. ErrorException-&gt;() C:\xampp\htdocs\psdsystems\app\Http\Controllers\CustomerController.php:35
  2. Illuminate\Foundation\Bootstrap\HandleExceptions-&gt;handleError() C:\xampp\htdocs\psdsystems\app\Http\Controllers\CustomerController.php:35
  3. App\Http\Controllers\CustomerController-&gt;store() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Controller.php:54
  4. call_user_func_array() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Controller.php:54
  5. Illuminate\Routing\Controller-&gt;callAction() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\ControllerDispatcher.php:45
  6. Illuminate\Routing\ControllerDispatcher-&gt;dispatch() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Route.php:219
  7. Illuminate\Routing\Route-&gt;runController() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Route.php:176
  8. Illuminate\Routing\Route-&gt;run() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Router.php:680
  9. Illuminate\Routing\Router-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:30
 10. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Middleware\SubstituteBindings.php:41
 11. Illuminate\Routing\Middleware\SubstituteBindings-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 12. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 13. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Middleware\ThrottleRequests.php:58
 14. Illuminate\Routing\Middleware\ThrottleRequests-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 15. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 16. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:104
 17. Illuminate\Pipeline\Pipeline-&gt;then() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Router.php:682
 18. Illuminate\Routing\Router-&gt;runRouteWithinStack() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Router.php:657
 19. Illuminate\Routing\Router-&gt;runRoute() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Router.php:623
 20. Illuminate\Routing\Router-&gt;dispatchToRoute() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Router.php:612
 21. Illuminate\Routing\Router-&gt;dispatch() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:176
 22. Illuminate\Foundation\Http\Kernel-&gt;Illuminate\Foundation\Http\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:30
 23. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\fideloper\proxy\src\TrustProxies.php:57
 24. Fideloper\Proxy\TrustProxies-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 25. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 26. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php:21
 27. Illuminate\Foundation\Http\Middleware\TransformsRequest-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 28. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 29. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\TransformsRequest.php:21
 30. Illuminate\Foundation\Http\Middleware\TransformsRequest-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 31. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 32. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\ValidatePostSize.php:27
 33. Illuminate\Foundation\Http\Middleware\ValidatePostSize-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 34. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 35. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode.php:62
 36. Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode-&gt;handle() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:163
 37. Illuminate\Pipeline\Pipeline-&gt;Illuminate\Pipeline\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Routing\Pipeline.php:53
 38. Illuminate\Routing\Pipeline-&gt;Illuminate\Routing\{closure}() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php:104
 39. Illuminate\Pipeline\Pipeline-&gt;then() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:151
 40. Illuminate\Foundation\Http\Kernel-&gt;sendRequestThroughRouter() C:\xampp\htdocs\psdsystems\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php:116
 41. Illuminate\Foundation\Http\Kernel-&gt;handle() C:\xampp\htdocs\psdsystems\public\index.php:55

I already changed my primary key inside my model since i made my primary key which is usually just "id" to "CustomerID"

API:

<?php

use Illuminate\Http\Request;

Route::middleware('auth:api')->get('/user', function (Request $request) {
    return $request->user();
});

//List Customers Details
Route::get('customers','CustomerController@index');

//List Single Customer Detail
Route::get('customer/{CustomerID}','CustomerController@show');

//Create new Customer Details
Route::post('customer','CustomerController@store');

//Update Customer Details
Route::put('customer','CustomerController@store');

//Delete Customer Details
Route::delete('customer/{CustomerID}','CustomerController@destroy');

Controller:

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Customer;
use App\Http\Resources\Customer as CustomerResource;

class CustomerController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        // Get customer details
        $customers = Customer::paginate(10);

        //Return collection of Customers as a resource
        return CustomerResource::collection($customers);
    }


    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $customer = $requests->isMethod('put') ? Customer::findOrFail($request->CustomerID) : new Customer;

        $customer->CustomerID = $request->input('CustomerID');
        $customer->Customer = $request->input('Customer');
        $customer->Address = $request->input('Address');

        if($customer->save()) {
            return new CustomerResource($customer);
        }
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $CustomerID
     * @return \Illuminate\Http\Response
     */
    public function show($CustomerID)
    {
        //Get single customer detail
        $customer = Customer::findOrFail($CustomerID);

        //Return single customer as a resource
        return new CustomerResource($customer);



    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($CustomerID)
    {
         //Get single customer detail
         $customer = Customer::findOrFail($CustomerID);

         if($customer->delete()) {
            return new CustomerResource($customer);
         }
    }
}

Model:

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;

class Customer extends Model
{
    protected $primaryKey = 'CustomerID';

}

I expect that the post request will actually function

hazem ali · Accepted Answer · 2019-04-13 10:50:12Z

2

There is a typo here

    public function store(Request $request)
    {
        $customer = $requests->isMethod('put') ? Customer::findOrFail($request->CustomerID) : new Customer;

an extra s in request variable it should be

    public function store(Request $request)
    {
        $customer = $request->isMethod('put') ? Customer::findOrFail($request->CustomerID) : new Customer;

edited Apr 13, 2019 at 10:50

answered Apr 13, 2019 at 10:47

hazem ali

3012 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rouhollah Mazarei · Accepted Answer · 2019-04-13 10:46:56Z

0

there is a typo in your code:

$customer = $requests->isMethod('put') ? Customer::findOrFail($request->CustomerID) : new Customer; // remove the `s`, it's $request

That must be:

$customer = $request->isMethod('put') ? Customer::findOrFail($request->CustomerID) : new Customer;

answered Apr 13, 2019 at 10:46

Rouhollah Mazarei

4,1631 gold badge18 silver badges20 bronze badges

Collectives™ on Stack Overflow

Laravel API ErrorException: Undefined variable:

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related