C Stack Error Linked LIst

Question

There are huge amounts of error, Seriously what's wrong ? I tried using it wihout typedef but what's the problem? can anyone help me debug this please?

struct node {
    int info;
    struct node *link;
};

int main (void)
{
    int choice;
    struct node *top;
    top = NULL;
    while (1) {
        printf("1.Push\n");
        printf("2.Pop\n");
        printf("3.Display\n");
        printf("4.Quit\n");
        printf("Enter your choice : ");
        scanf("%d", &choice);

        switch(choice) {
            case 1:
                push();
                break;
            case 2:
                pop();
                break;
            case 3:
                display();
                break;
            case 4:
                exit(1);
            default:
                printf("Wrong choice\n");
        }
    }
    return 0;
}

void push (void)
{
    struct node *tmp;
    int pushed_item;
    tmp = malloc(sizeof(struct node));
    printf("Input the new value to be pushed on the stack : ");
    scanf("%d", &pushed_item);
    tmp->info = pushed_item;
    tmp->link = top;
    top = tmp;
}

void pop (void)
{
    struct node *tmp;
    if (top == NULL)
        printf("Stack is empty\n");
    else {
        tmp = top;
        printf("Popped item is %d\n", tmp->info);
        top = top->link;
        free(tmp);
    }
}

void display (void)
{
    struct node *ptr;
    ptr = top;
    if (top == NULL)
     printf("Stack is empty\n");
    else {
        printf("Stack elements :\n");
        while (ptr != NULL) {
            printf("%d\n", ptr->info);
            ptr = ptr->link;
        }
    }
}

And what are the errors you're getting? Please post the precise error messages. — Oliver Charlesworth
– Oliver Charlesworth, Commented Apr 6, 2011 at 23:15
Please post the compiler you are using, the compiler options you are using, and the specific error output that you are seeing. — bta
– bta, Commented Apr 7, 2011 at 0:01

Borealid · Accepted Answer · 2011-04-06 23:17:56Z

1

First off, the main function is going to have to be below the functions it calls. Secondly, you need to #import <stdio.h> to use printf. Thirdly, top is not a global variable so you can't just use it inside the display function.

Work from there.

answered Apr 6, 2011 at 23:17

Borealid

99.4k9 gold badges111 silver badges123 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

corsiKa Over a year ago

#import or #include - too much Java there buddy!

corsiKa Over a year ago

Also, if his code is structured correctly, his functions are in a .h file, and this is just his code file. (Note, that's an if. And by the looks of the code, a big if.)

Gavin H Over a year ago

The main function does not have to be below the functions it calls - just prototype the other functions up above (should be in a header file generally).

Marlon · Accepted Answer · 2011-04-07 00:36:57Z

1

Try putting this snippet at the top of your file:

#include <stdio.h>
#include <stdlib.h>

void push(void);
void pop(void);
void display(void);

struct node* top; // good catch by Borealid

edited Apr 7, 2011 at 0:36

answered Apr 7, 2011 at 0:06

Marlon

20.3k14 gold badges77 silver badges106 bronze badges

1 Comment

Jess Over a year ago

You will also need #include<stdlib.h> for the exit and free.

Collectives™ on Stack Overflow

C Stack Error Linked LIst

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related