Linked List Push Function

Question

#include <stdio.h>
#include <stdlib.h>
#include <conio.h>

struct stackNode
{
    int data;
    struct stackNode *nextPtr;
};


void instructions()
{
    printf("[1]Push a value on the stack\n");
    printf("[2]Pop a value off the stack\n");
    printf("[3]Display the whole stack\n");
    printf("[4]Exit");
} 

void push(struct stackPtr *topPtr, int info)
{
    struct stackPtr *newPtr;
    newPtr= malloc(sizeof(struct stackNode));
    if(newPtr !=NULL)
    {
        newPtr->data = info;
        newPtr->nextPtr=*topPtr;
        *topPtr=newPtr;
    }
    else
    {
        printf("%d not inserted no memory available");
    }

int main()
{
    struct StackNodePtr *stackPtr;
    stackPtr = NULL;
    int choice, value;
    do
    {   
        instructions();
        printf("\nEnter Your Choice: ");
        scanf("%d",&choice);
        if(choice == 1)
        {
            printf("Enter  a value for the stack");     
        }             
        if(choice == 2)
        {
            printf(" "); 
        }       
        if(choice == 3)
        {
            printf(" ");
        }
        if(choice == 4 )
        {
            printf("bye!");
            return 0;
        }
    } while(choice !=4);
    system("pause");
}

I made a function push for my linked list and stack code but the thing is it's not working there are Enormous errors in the function push what's wrong with it? it's not allowing the malloc to be used why is that?

OMG, this is like the sixth question about pretty much the same thing ... You're really grinding on that list, aren't you? — unwind
– unwind, Commented Apr 7, 2011 at 10:09

John Källén · Accepted Answer · 2011-04-07 10:07:30Z

2

Does this work for you?

struct stackNode { int data; struct stackNode *nextPtr; };

int main() { struct stackNode * stackPtr = NULL; }

answered Apr 7, 2011 at 10:07

John Källén

8,04338 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Kyel John M David Philippines Over a year ago

is this the same as this ?? struct stackNode *stackPtr; stackPtr = NULL;??

John Källén Over a year ago

It is, but I prefer the style in my answer as I like to explicitly initialize my definitions.

Heisenbug · Accepted Answer · 2011-04-07 10:31:56Z

2

struct stackNode
{
   int data;
   struct stackNode *nextPtr;
};

int main()
{
    struct stackNode *stackPtr = NULL;
}

edited Apr 7, 2011 at 10:31

answered Apr 7, 2011 at 10:08

Heisenbug

39.3k30 gold badges139 silver badges192 bronze badges

1 Comment

Fred Foo Over a year ago

You're creating a global variable.

user166390 · Accepted Answer · 2011-04-07 10:07:01Z

1

// just precede the struct type with ... struct
struct stackNode* stackPtr = NULL;

Happy coding.

answered Apr 7, 2011 at 10:07

user166390

2 Comments

Kyel John M David Philippines Over a year ago

how about this? can anyone transcribe this too? typedef struct stackNode StackNode; typedef struct StackNode *StackNodePtr;

user166390 Over a year ago

Just take them out? If they aren't being used, they aren't being used.

GrahamS · Accepted Answer · 2011-04-07 10:36:04Z

1

This line:

typedef struct StackNode *StackNodePtr;

is wrong by the way. Your typedefs should be:

typedef struct stackNode StackNode;
typedef StackNode* StackNodePtr;

No idea why you're against using typedef - it tends to make the code a lot more readable.

edited Apr 7, 2011 at 10:36

answered Apr 7, 2011 at 10:09

GrahamS

10.4k10 gold badges51 silver badges64 bronze badges

3 Comments

Kyel John M David Philippines Over a year ago

I just want to keep it simple and it confuses me a lot ooppp sorry how do I fix this ?? typedef struct stackNode StackNode; typedef StackNode* StackNodePtr; without any typdefs?

GrahamS Over a year ago

@Kyel: I think the other answers from @John Källén, @pst and @0verbose already show you how to write your code without typedef - if that is not what you want then you need to reword your question.

Kyel John M David Philippines Over a year ago

soo to sum it all up, it's only like that??

Collectives™ on Stack Overflow

Linked List Push Function

4 Answers 4

2 Comments

1 Comment

2 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related