unable to insert into mysql database using php

Question

$db = mysql_connect("localhost","root","123");
mysql_select_db("website_categorization") or die("\n error selecting database" );
$keyword_array = preg_split('/[\s,]+/', $tag);                              
foreach($keyword_array as $tag1)                                                      
{
    mysql_query("INSERT INTO category_keyword(ID_Category, Keyword) VALUES(2,$tag1)");
}

echo "\nAffected rows are ".mysql_affected_rows()."\n";
mysql_close($db);

Can u tell me what is the problem with this code??...I intend to insert rows into the category_keyword table from an array $keyword_array. I get errors "Affected rows are -1" and insertion does not work

Your Common Sense · Accepted Answer · 2011-04-07 10:21:20Z

1

You should quote and escape string values.
You should also handle errors, to be notified of them.
You should also write distinct statements, to be able to read your code later (as well as let others to read it).

$tag1 = mysql_real_escape_string($tag1);
$sql  = "INSERT INTO category_keyword(ID_Category, Keyword) VALUES(2,'$tag1')";
mysql_query($sql) or trigger_error(mysql_error()." in ".$sql);

answered Apr 7, 2011 at 10:21

Your Common Sense

158k42 gold badges226 silver badges373 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Your Common Sense Over a year ago

@user641086 you're welcome. Hope you learned some good practice from my answer, to use it with every query you run in your scripts.

Community · Accepted Answer · 2017-05-23 09:58:44Z

1

insert multiple rows via a php array into mysql

edited May 23, 2017 at 9:58

CommunityBot

11 silver badge

answered Apr 7, 2011 at 10:09

miqbal

2,2373 gold badges28 silver badges35 bronze badges

Comments

Elijan · Accepted Answer · 2011-04-07 10:11:20Z

0

You need to encapsulte the string $tag in a query, otherwise mysql will think its a column name

  mysql_query("INSERT INTO category_keyword(ID_Category, Keyword) VALUES(2,'".mysql_real_escape_string($tag1)."')");

answered Apr 7, 2011 at 10:11

Elijan

1,4161 gold badge8 silver badges11 bronze badges

Comments

Shakti Singh · Accepted Answer · 2011-04-07 10:21:56Z

0

You should quote and escape your string columns

$tag1 = mysql_real_escape_string($tag1); mysql_query("INSERT INTO category_keyword(ID_Category, Keyword) VALUES(2,'$tag1')");

You should also handle the mysql query errors to know why the query get failed. With the current code you never know why it is failing.It is better to handle mysql errors.

mysql_query('Your query') or trigger_error(mysql_error());

edited Apr 7, 2011 at 10:21

answered Apr 7, 2011 at 10:11

Shakti Singh

86.7k21 gold badges142 silver badges156 bronze badges

Comments

Blagomir · Accepted Answer · 2011-04-07 10:17:17Z

-1

You can use this:

mysql_query("INSERT INTO category_keyword SET ID_Category=2, Keyword=".$tag1.");

Better syntax to understand :)

answered Apr 7, 2011 at 10:17

Blagomir

2532 silver badges9 bronze badges

2 Comments

Christophe Over a year ago

that's the syntax for UPDATE query. Even if it would work I would never use it this way!

Your Common Sense Over a year ago

@krike in fact, it's quite handy to have similar syntax for both types, lets you reuse your code

Collectives™ on Stack Overflow

unable to insert into mysql database using php

5 Answers 5

1 Comment

Comments

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related