Postgres syntax in node-postgres for function call

Question

Here is how I call postgres from my node.js app using express

const db_pg = require("./db-pg");
app.get('/pg/', (req,res,next) => {
    db_pg.query(req).then((body) => {
        res.send(body);
    }).catch((err) => {
        next(err);
    })
});

And within my db-pg/index.js file (not including the detail of the pool setup):

module.exports = {
    query: (req) => {
        return pool.query(req);
    }
};

I am getting the following error from postgreSQL :

syntax error at or near ","

The query I am trying to execute is :

req = {
    text: "SELECT * from my_func(?,?,?)",
    values: ["the_name", 20190303, 20190620]
}

What is wrong in my syntax ?

Assuming you're using node-postgres, it looks like it should be "SELECT * FROM my_func($1, $2, $3)": node-postgres.com/features/queries#parameterized-query — Chris White
– Chris White, Commented Apr 29, 2019 at 14:18

Urigo · Accepted Answer · 2020-02-15 15:02:29Z

2

Just turning Chris White's comment into an answer:

node-postgres recommends to use parameterized-queries for passing parameters.

Here is the correct syntax for the SQL (all the rest looks fine):

"SELECT * FROM my_func($1, $2, $3)"

answered Feb 15, 2020 at 15:02

Urigo

3,18523 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

narayansharma91 · Accepted Answer · 2019-04-29 11:10:04Z

0

It should be like below.

req = {
    text: "SELECT * from my_func(?,?,?)",
    values: ["the_name", 20190303, 20190620]
}

answered Apr 29, 2019 at 11:10

narayansharma91

2,3531 gold badge14 silver badges20 bronze badges

1 Comment

Chapo Over a year ago

wish it were that simple. typo fixed in the question

Collectives™ on Stack Overflow

Postgres syntax in node-postgres for function call

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related