How to fetch values from if else condition?

Question

I am trying to get a code using if else condition.I wish to take values from if else condition .

Currently if condition works, not working for else condition.

mname=input("Enter  name: ")
    m=[]

        if mname=="CS1TFD22" or "cs1tfd22":
            mcode='CS122S003'
            if l1l2=="NULL":
                icode = 'CS122S003d13_mh_'
            elif l1l2!="NULL":
                icode = 'CS122S003d13_L1_mh_'

        else:
            for i in mname:
                m.append(i)

            mcode = 'CS1'+m[5]+m[6]+'S003'
            if l1l2=="NULL":
                icode='CS1'+m[5]+m[6]+'S003d113_mh_'
            elif l1l2 != "NULL":
                icode = CS1'+m[5]+m[6]+'S003d13_L1_mh_'

        print(mcode,icode)

Output I get is always mcode='CS122S003' and icode='CS122S003d13_L1_mh_', if mname is not 'CS1TFD22'. For example if I enter mname as CS1TFD23 , then icode should be 'CS123S003' and icode should be 'CS123S003d13_mh'

How to work for else condition also?

This is wrong for sure if mname=="CS1TFD22" or "cs1tfd22":, should be if mname in ("CS1TFD22" ,"cs1tfd22"): — Netwave
– Netwave, Commented May 1, 2019 at 5:45
Possible duplicate of How to test multiple variables against a value? — Paritosh Singh
– Paritosh Singh, Commented May 1, 2019 at 5:45
What is the code supposed to do? Please include that explanation in your code too! — Devesh Kumar Singh
– Devesh Kumar Singh, Commented May 1, 2019 at 5:47
Correct your first if statement like this if mname=="CS1TFD22" or mname=="cs1tfd22": — Paandittya
– Paandittya, Commented May 1, 2019 at 5:47

Keelan Pool · Accepted Answer · 2019-05-01 05:48:38Z

2

Your if statement is always evaluating true, as you are evaluating the logical true/false of a string. You should use

if mname=="CS1TFD22" or mname=="cs1tfd22":

or

if mname in ("CS1TFD22","cs1tfd22"):

answered May 1, 2019 at 5:48

Keelan Pool

1771 silver badge16 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mr.Robot Over a year ago

Your never which character would be Upper or Lower Case. So its better to use casefold()

Keelan Pool Over a year ago

I actually didn't even notice that they were the same string in a different case! In that case yes, should definitely use casefold()

Devesh Kumar Singh · Accepted Answer · 2019-05-01 06:09:55Z

1

Some errors in your code

You check for two or conditions not by if mname=="CS1TFD22" or "cs1tfd22":, but by if mname=="CS1TFD22" or mname=="cs1tfd22":, also you can simplify this by doing if mname.lower()=="cs1tfd22": .
You don't need the extra elif in if l1l2=="NULL":, just else would do .
You missed a single quote in icode = CS1'+m[5]+m[6]+'S003d13_L1_mh_'
You have not defined li2 anywhere, not sure where you are taking it from, so I am taking it as input in my code

The code with all these issues might look like so

mname=input("Enter name: ")
l1l2=input("Enter l1l2")
m=[]

#Convert mname to lower case and then compare
if mname.lower() == 'cs1tfd22':
    mcode='CS122S003'

    #If-else case 1
    if l1l2=="NULL":
        icode = 'CS122S003d13_mh_'
    else:
        icode = 'CS122S003d13_L1_mh_'

else:
    for i in mname:
        m.append(i)
    mcode = 'CS1'+m[5]+m[6]+'S003'

    # If-else case 1
    if l1l2=="NULL":
        icode='CS1'+m[5]+m[6]+'S003d113_mh_'
    else:
        icode = 'CS1'+m[5]+m[6]+'S003d13_L1_mh_'

print(mcode,icode)

Some outputs from your code will be.

Enter name: cs1tfd22
Enter l1l2:  NULL
CS122S003 CS122S003d13_mh_

Enter name: abcdefgh
Enter l1l2:  NULL
CS1fgS003 CS1fgS003d113_mh_

Enter name: xyzabcd
Enter l1l2:  HELLO
CS1cdS003 CS1cdS003d13_L1_mh_

edited May 1, 2019 at 6:09

answered May 1, 2019 at 5:58

Devesh Kumar Singh

20.5k5 gold badges25 silver badges43 bronze badges

9 Comments

Netwave Over a year ago

` also you can simplify this by doing if mname.lower()=="CS1TFD22":` this is wrong, should be mname.upper()

Devesh Kumar Singh Over a year ago

Damn! I put it correctly in the code but incorrectly in the example! I corrected them at both places! thanks @Netwave Please take a look again and if it looks good, please consider upvoting

Netwave Over a year ago

its ok now, gj :)

Devesh Kumar Singh Over a year ago

What's gj! I don't know this!

Devesh Kumar Singh Over a year ago

Aah damn! Still learning the ropes of SO so any feedback is always appreciated @Netwave Especially from a high rep user like you :)

|

Mr.Robot · Accepted Answer · 2019-05-01 05:48:09Z

1

Instead of

if mname=="CS1TFD22" or "cs1tfd22":

use

 if mname=="CS1TFD22" or mname=="cs1tfd22":

answered May 1, 2019 at 5:48

Mr.Robot

3531 gold badge2 silver badges14 bronze badges

2 Comments

Mr.Robot Over a year ago

or you can use casefold() also

Marc Wagner Over a year ago

this is correct. "cs1tfd22" allways evaluates to True, so the else condition is never hit

Hamidreza Soltani · Accepted Answer · 2019-05-01 07:24:10Z

0

You should define l1l2 variable.
Use else instead elif.

Don't forget ' mark before CS1 at the last line.

mname=input("Enter  name: ")
m=[]
l1l2=input("Enter  l1l2: ")

if mname=="CS1TFD22" or "cs1tfd22":
    mcode='CS122S003'
    if l1l2=="NULL":
        icode = 'CS122S003d13_mh_'
    else:
        icode = 'CS122S003d13_L1_mh_'
else:
    for i in mname:
        m.append(i)

    mcode = 'CS1'+m[5]+m[6]+'S003'
    if l1l2=="NULL":
        icode='CS1'+m[5]+m[6]+'S003d113_mh_'
    else:
        icode = 'CS1'+m[5]+m[6]+'S003d13_L1_mh_'

print(mcode,icode)

answered May 1, 2019 at 7:24

Hamidreza Soltani

6646 silver badges12 bronze badges

Collectives™ on Stack Overflow

How to fetch values from if else condition?

4 Answers 4

2 Comments

9 Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

9 Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related