How to enter timestamp format from java to oracle database that also has format timestamp?

Question

I have this table in SQL Oracle database

MESSAGES
--------
Name           Null?    Type           
-------------- -------- -------------- 
ID_MESSAGE      NOT NULL NUMBER(38)     
CONTENT          NOT NULL NVARCHAR2(500) 
TIME_STAMP NOT NULL TIMESTAMP(6)

And I'm trying to insert a data into this table but I'm having a problem with inserting a timestamp.

I've generated a timestamp in Java and executed the following query:

Timestamp timeStamp = new Timestamp(System.currentTimeMillis());


String query = "INSERT INTO messages(content, time_stamp) VALUES ('"+textAreaSendMessage.getText()+"', "+timeStamp+")";

st.executeQuery(query);

And I'm getting this error:

Caused by: java.sql.SQLSyntaxErrorException: ORA-00917: missing comma

How to fix this so it inserts timestamp into a database?

Use parameters with types. Don't munge query strings.

Gordon Linoff
– Gordon Linoff

2019-05-04 15:20:10 +00:00
Commented May 4, 2019 at 15:20 — Gordon Linoff
– Gordon Linoff, Commented May 4, 2019 at 15:20

Basil Bourque · Accepted Answer · 2019-05-06 19:03:39Z

2

Use DEFAULT when defining your table to call a function that captures the current moment. This function will automatically run every time you INSERT a new row. Then no need for any Java for this purpose.

If you do want to do something like this in Java, do not use java.time.Timestamp. That class was supplanted years ago by the java.time classes.

OffsetDateTime odt = OffsetDateTime.now( ZoneOffset.UTC ) ;

Build your SQL string using ? placeholders. Do not wrangle with string manipulations as seen in your code sample.

Pass the OffsetDateTime object to fill in for the ? placeholder using a PreparedStatement object.

myPreparedStatement.setObject( … , odt ) ;

edited May 6, 2019 at 19:03

answered May 4, 2019 at 15:39

Basil Bourque

347k130 gold badges950 silver badges1.3k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Antrophy Over a year ago

Thank you for your recommendation. I will make sure to change all statements in the code to this format as it's more clear in the code and I don't have to search for ' character every single time I am trying to insert something as a String.

Antrophy · Accepted Answer · 2019-05-06 18:51:27Z

0

I found out that I don't even have to create timestamp in java, just add CURRENT_TIMESTAMP to the place of timestamp into the query where Timestamp should be.

edited May 6, 2019 at 18:51

answered May 4, 2019 at 15:30

Antrophy

296 bronze badges

Collectives™ on Stack Overflow

How to enter timestamp format from java to oracle database that also has format timestamp?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related