array.select not iterating through every element

Question

I have a rails controller and this code only loop through the first element in the metrics array? Why is that?

# /metrics/:id
def values
  @metric = metrics.select do |metric|
    id = metric['href'].split('/').last
    p "id == params[:id] = #{id == params[:id]}" # false on the first iteration (but never gets to the next iteration
    return id == params[:id]
  end
  p "HERE?" # We never get here!
end

AMHOL · Accepted Answer · 2019-05-20 03:15:23Z

2

You need to remove the return statement from your method, Ruby uses implicit return (see https://jtrudell.github.io/blog/ruby_return_values/), so the result of a block is the last line that is evaluated in that block, the return statement in your code is treated as a return from the values method. Your method needs to look something like:

def values
  @metric = metrics.select do |metric|
    metric['href'].split('/').last == params[:id]
  end
end

answered May 20, 2019 at 3:15

AMHOL

1444 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Catfish Over a year ago

Oh i thought for every implicit return you could have an explicit return. Guess not.

mu is too short Over a year ago

@Catfish Every implicit return from a method or lambda, not blocks though.

Stefan Over a year ago

@Catfish next is to blocks what return is to methods.

Collectives™ on Stack Overflow

array.select not iterating through every element

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related