using passed arguments in bash script

Question

I am passing two date values to a script and trying to use those in a CURL POST command as below:

starttime=$1
endtime=$2

for apps in $(cat testapps.txt)
do
    curl -X POST -H "Content-type: application/vnd.appd.cntrl+json;v=1" -d '{"name": "This is a test","timeRange": {"startTimeMillis":"$1","endTimeMillis":"$2"}, "affects": {"type": "APP"}}'

It is giving me 500 internal server error.

If I replace the $1 and $2 value with the date/time as below, it works fine.

curl -X POST -H "Content-type: application/vnd.appd.cntrl+json;v=1" -d '{"name": "This is a test","timeRange": {"startTimeMillis":"2019-05-28T15:00:00-0400","endTimeMillis":"2019-05-28T16:00:00-0400"}, "affects": {"type": "APP"}}'

Am I missing anything?

you are using the variables $1 and $2 inside single quotes. see after -d you are using single quotes. In bash you cannot expand the variable when its inside single quote. Try using double quotes. — P....
– P...., Commented May 28, 2019 at 18:47
Add a shebang and then paste your script there: shellcheck.net — Cyrus
– Cyrus, Commented May 28, 2019 at 18:53
Getting this error when I replace single quote with double - curl: (6) Could not resolve host: is; Unknown error curl: (6) Could not resolve host: a; Unknown error curl: (3) [globbing] unmatched close brace/bracket at pos 120 — bhaskar Khanal
– bhaskar Khanal, Commented May 28, 2019 at 19:09
you need to properly escape it before using it, as the input json already contains double quotes. — P....
– P...., Commented May 28, 2019 at 19:25

Paul Hodges · Accepted Answer · 2019-05-28 20:20:31Z

1

First, Dont Read Lines With For.

while read apps
do args=( 
    -X POST
    -H "Content-type: application/vnd.appd.cntrl+json;v=1"
    -d '{ "name":"This is a test",
          "timeRange": { 
              "startTimeMillis": "'"$1"'",
              "endTimeMillis": "'"$2"'" }, 
          "affects": {"type": "APP"}}'
   ) 
   # don't you need a URL here?
   curl "${args[@]}" "$apps" # added $apps, assuming that was missing...
done < testapps.txt

edited May 28, 2019 at 20:20

answered May 28, 2019 at 19:39

Paul Hodges

16k1 gold badge24 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

using passed arguments in bash script

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related