how to avoid stack overflow exception in this code?

Question

I got StackOverflowException in my code

 public int Movie_ID
 {
     set
     {
         if (value == 0)
         {
             throw new Exception("value cannot be empty");
         }

         Movie_ID = value;
     }
     get
     {
         return Movie_ID;
     }
 }

Exception of type 'System.StackOverflowException' was thrown."}

public int MovieID { set { value = r1.Next(1, 10); MovieID = value; } get { return MovieID; } } — jitender singh
– jitender singh, Commented May 31, 2019 at 10:08
return Movie_ID; calls Movie_ID; which calls (via property) return Movie_ID; etc. — Dmitrii Bychenko
– Dmitrii Bychenko, Commented May 31, 2019 at 10:11

Owen Pauling · Accepted Answer · 2019-05-31 10:10:52Z

6

Your get keeps calling itself recursively. You need to create a backing field and return that value, not call the property again. e.g:

private int _movieId;

public int Movie_ID
 {
     set
     {
         if (value == 0)
         {
             throw new Exception("value cannot be empty");
         }

         _movieId = value;
     }
     get
     {
         return _movieId;
     }
 }

answered May 31, 2019 at 10:10

Owen Pauling

12.1k20 gold badges58 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Dmitrii Bychenko Over a year ago

side note: throw new Exception("value cannot be empty"); is evil; throw new ArgumentOutOfRangeException(nameof(value), "...") or alike

Hans Keﬆing Over a year ago

And if you are checking the value anyway, is negative allowed?

Collectives™ on Stack Overflow

how to avoid stack overflow exception in this code?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related