scrape html source vba

Question

I need to scrape some info from web, using vba. This is an extract of my code. It's ok, but the site has 2 classes with the same name. So my code writes only the last value. I want that:

Sheets("01").Range("DW" & number) = source.getAttribute("data-id")

writes only the first value of class "sample" found on site.

How can I do? Thanks

 With http
    .Open "GET", site, False                
    .send
    html.body.innerHTML = .responseText
End With
For Each source In html.getElementsByClassName("sample")

Sheets("01").Range("DW" & number) = source.getAttribute("data-id")  

       
Next source
Next number

It seems you're not showing all of your (relevant) code. You have a Next number-statement but no matching For or For Each ? — FunThomas
– FunThomas, Commented Jun 7, 2019 at 14:57

user6585761 · Accepted Answer · 2019-06-07 15:04:04Z

2

To refer to the first element of a class collection, you can use the Item property, for which the index is 0-based. So you can replace your For Each/Next with the following line...

Sheets("01").Range("DW" & Number) = html.getElementsByClassName("sample").Item(0).getAttribute("data-id")

Hope this helps!

answered Jun 7, 2019 at 15:04

user6585761

Sign up to request clarification or add additional context in comments.

Comments

QHarr · Accepted Answer · 2019-06-07 17:08:11Z

2

You can be more efficient by using querySelector, which only returns the first match rather than an entire collection (or nodeList)

Sheets("01").Range("DW" & Number) = html.querySelector(".sample").getAttribute("data-id")

edited Jun 7, 2019 at 17:08

answered Jun 7, 2019 at 16:40

QHarr

84.5k14 gold badges58 silver badges105 bronze badges

Collectives™ on Stack Overflow

scrape html source vba

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related