Can't change text in 'on click' javascript

Question

I am doing a 'if,else' statement in javaScript. I want to change the "h2" text. I think I'm missing some code

<div id="game"> 
  <p id="howMany">How many fingers am I holding up?</p> 
  <p id="theGame"> <input type="guess" id="guess" placeholder="0 to 5"> 
    <button id="check-guess"> Guess! </button> 
  </p> 
  <div id="theAnswer"> 
    <h2 id="h2">Your Reward</h2> 
  </div> 
</div>

document.getElementById("check-guess").onclick = function() {
  var randomNumber = Math.random();
  randomNumber = randomNumber * 6;
  randomNumber = Math.floor(randomNumber);
  if (document.getElementById("guess").value == randomNumber) {
    document.getElementsById("h2").innerHTML = "You got it!";
                         } else {
    document.getElementsById("h2").innerHTML = "Nope! Try Again. The number is " +  randomNumber ;
  }
}

You need to add an id to the H2 and reference it that way. You are trying to pass a tag name instead of the id — JasonB
– JasonB, Commented Jun 12, 2019 at 15:33

JasonB · Accepted Answer · 2019-06-12 15:37:26Z

2

Your function getElementsById doesn't exist, it could be getElementById. The value you pass needs to be an id, not a tagname.

document.getElementById("check-guess").onclick = function() {

  var randomNumber = Math.random();

  randomNumber = randomNumber * 6;

  randomNumber = Math.floor(randomNumber);

  if (document.getElementById("guess").value == randomNumber) {

    document.getElementById("h2").innerHTML = "You got it!";

  } else {

    document.getElementById("h2").innerHTML = "Nope! Try Again. The number is " + randomNumber;
  }
}

<input id="guess">
<button id="check-guess">Check</button>
<h2 id="h2">Test</h2>

answered Jun 12, 2019 at 15:37

JasonB

6,4182 gold badges19 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Can't change text in 'on click' javascript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related