How to fix "TypeError: Cannot read property 'length' of undefined" in javascript [duplicate]

Question

This is the constructor for the group class that acts similarly to a set.

    constructor(){
        this.list = [];
    }

    [Symbol.iterator](){
        return new GroupIterator(this.list);
    }

This should make group objects itterable but I can't find the error.

class GroupIterator{

    constructor(group){
        this.group = group;
        this.position = 0;
    }

    next(){
        let result = {
            value: undefined,
            done: true,
        };
        if(this.position >= this.group.list.length){
            return result;
        }
        result.value = group.list[this.position];
        result.done = false;
        this.position++;
        return result;

    }
}

when you are debugging, what do you receive as a parameter in your constructor — Pietro Nadalini
– Pietro Nadalini, Commented Jun 26, 2019 at 21:27

Shmish · Accepted Answer · 2019-06-26 21:35:36Z

0

Looks like you have a small error here, it should be this.group.length, not this.group.list.length, the list IS named group. For reference:

class GroupIterator{
  constructor(group){
    this.group = group
    this.position = 0
  }

  next() {
    let result = {
      value: undefined,
      done: true,
    }

    if(this.position >= this.group.length){
      return result
    }

    result.value = this.group[this.position]
    result.done = false
    this.position++
    return result
  }
}

edited Jun 26, 2019 at 21:35

answered Jun 26, 2019 at 21:30

Shmish

1535 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Barmar Over a year ago

group[this.position] should be this.group[this.position]

Jack Bashford · Accepted Answer · 2019-06-26 21:37:44Z

0

Because your property is called group - there's no list attached, because group is the array you passed to the constructor.

if (this.position >= this.group.length) {...}

And make sure to replace group[this.position] with this.group[this.position].

edited Jun 26, 2019 at 21:37

answered Jun 26, 2019 at 21:31

Jack Bashford

44.3k11 gold badges56 silver badges84 bronze badges

2 Comments

Barmar Over a year ago

Also this.group[this.position]

Jack Bashford Over a year ago

Ok @Barmar, I'll add that

Collectives™ on Stack Overflow

How to fix "TypeError: Cannot read property 'length' of undefined" in javascript [duplicate]

2 Answers 2

1 Comment

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Linked

Related