PHP OOP Problem

Question

This is my parent class:

class Model extends CI_Model
{
    protected $table, $idField='id';
    public $fields;

    function __construct()
    {
        parent::__construct();
        $this->fields  = new ValFieldGroup();
    }
    //Other Code
}

Here's the code of the ValFieldGroup class:

class ValFieldGroup
{
    private $fields = array();

    public function add($name, $rules = '', $label = '')
    {
        $this->fields[$name] = new ValField($name, $rules, $label);
    }

    public function __get($name)
    {
        if (isset($this->fields[$name]))
            return $this->fields[$name];
        else
            return false;
    }

    public function __set($name, $value)
    {
        $this->fields[$name] = $value;
    }

    public function getAll()
    {
        return $this->fields;
    }
}

Here's the child class where I'm getting an error:

class User extends Model
{
    function __construct()
    {
        parent::__construct();

        $this->fields.add('first', 'required', 'First Name');
        // Snip
    }
    // Snip
}

I'm getting the following error when I run this code:

Fatal error: Call to undefined function add() in \models\user.php..

Which is this line in the class User:

$this->fields.add('first', 'required', 'First Name');

When I do a print_r($this->fields) before this line, I get:

ValFieldGroup Object ( [fields:private] => Array ( ) )

So clearly the class is being setup but I can't use the function I want.. what am I doing wrong?

fields.add is not valid syntax in PHP - if you have a property named $fields, it'd have to be $this->fields->add — Pekka
– Pekka, Commented Apr 15, 2011 at 17:45
@Peka - Actually, it's valid syntax by pure chance. It concatenates the $this->fields property with the output of function add(). — Álvaro González
– Álvaro González, Commented Apr 15, 2011 at 17:50

Gordon · Accepted Answer · 2011-04-15 17:51:31Z

7

Unless add is a function from the global scope, I'd say fields.add() should be fields->add(). The dot is the string concatenation operator in PHP.

edited Apr 15, 2011 at 17:51

answered Apr 15, 2011 at 17:45

Gordon

318k76 gold badges548 silver badges566 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Álvaro González Over a year ago

I tend use periods as member operator all the time xD

Jeff Lambert · Accepted Answer · 2011-04-15 17:45:20Z

2

Your User class extends SuperModel, not Model.

answered Apr 15, 2011 at 17:45

Jeff Lambert

24.7k4 gold badges72 silver badges98 bronze badges

Comments

Neil Aitken · Accepted Answer · 2011-04-15 17:47:51Z

2

You aren't calling the method correctly, try this:

class User extends Model
{
    function __construct()
    {
        parent::__construct();

        $this->fields->add('first', 'required', 'First Name');
        // Snip
    }
    // Snip
}

answered Apr 15, 2011 at 17:47

Neil Aitken

7,8393 gold badges44 silver badges40 bronze badges

Collectives™ on Stack Overflow

PHP OOP Problem

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related