Code in java to set images for ImageView?

Question

I'm kinda new to android development and having problem showing images from my drawable resource file with java code. I simplified my original app to isolate the problem, so now it is just a blank activity with one image view in the center.

xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
tools:context=".MainActivity">

<ImageView
    android:id="@+id/imageView000"
    android:layout_width="82dp"
    android:layout_height="82dp"
    android:layout_centerHorizontal="true"
    android:layout_centerVertical="true" />

public class MainActivity extends AppCompatActivity {

public ImageView images;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
}

@Override
protected void onStart() {
    super.onStart();
    images = findViewById(R.id.imageView000);
    images.setImageResource(R.drawable.imageNameInDrawableFile);

}

}

There is no error in compilation. But when I run this on the virtual device or my phone, the app crashes on start. What's wrong?

Update: thank for the tips everyone. the problem was the directory of the image, it was "E:\AndroidStudioProjects\TestApplication\app\src\main\res\drawable-v24", just removed the "-v24" in directory shown after i drop myImage into drawable folder and it worked perfectly after.

the app crashes on start. Whats wrong? Why don't you share crash log with question — AskNilesh
– AskNilesh, Commented Jul 9, 2019 at 10:59

Sagar Balyan · Accepted Answer · 2019-07-09 11:02:42Z

1

Use images.setImageResource(R.drawable.imageNameInDrawableFile);

setImageDrawable() requires a Drawable to be passed but you are passing an integer.

answered Jul 9, 2019 at 11:02

Sagar Balyan

6786 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ashish · Accepted Answer · 2019-07-09 11:31:37Z

0

Just use you're code in onCreate.

Cause onStart includes when the application is first created and when it is brought back on the screen without being terminated.

public ImageView images;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);
    images = findViewById(R.id.imageView000);
    images.setImageDrawable(ContextCompat.getDrawable(activity, R.drawable.your_image));
    //or
    images.setImageResource(R.drawable.your_image);
}

edited Jul 9, 2019 at 11:31

answered Jul 9, 2019 at 11:10

Ashish

6,9894 gold badges29 silver badges48 bronze badges

7 Comments

Datis Over a year ago

I moved those codes to onCreate, its the same: "Unfortunately, app has stopped."

Datis Over a year ago

Context activity = null; images.setImageDrawable(ContextCompat.getDrawable(activity, R.drawable.imageName)); //didnt work

Datis Over a year ago

images.setImageResource(R.drawable.your_image); // didnt work.

Ashish Over a year ago

@Datis you have to pass you're drawable make sure you have drawable present in drawable folder.

Datis Over a year ago

i found the problem, thanks for the tip mate. it was the directory of the image when i place it in drawable folder, "E:\AndroidStudioProjects\TestApplication\app\src\main\res\drawable-v24". just had to delete "-v24"... i was struggeling for 2 day!!!

|

Collectives™ on Stack Overflow

Code in java to set images for ImageView?

2 Answers 2

Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related