Adding a class to a button in jquery

Question

I am trying to add a css class to my button after some ajax:

$('a.vote-up-0').click(function() {

    var id = $(this).siblings('.reply-id').val();
    var ajax_auth_token = $('#auth_token').val();


    $.post('user/?action=ajax', {
        vote_type: 'up',
        reply_id: id,
        auth_token: ajax_auth_token
    }, function(data, return_status) {   

        var json_data = jQuery.parseJSON(data);

        switch(json_data.r_message)
        {
           case "success": 
              output = "Yay it works!"; // change 
               alert(output);
               $(this).addClass('vote-up-1'); // ** the culprit **
           break;

The alert works, however it does not add the class vote-up-1 to it. There are several instances of the same class (i.e. vote-up-0) on the page, so If I change (this) to 'vote-up-0', it changes all of them. Anyone have any ideas?

put alert after the culprit line and check

Nighil
– Nighil

2011-04-17 17:34:32 +00:00
Commented Apr 17, 2011 at 17:34 — Nighil
– Nighil, Commented Apr 17, 2011 at 17:34

Pointy · Accepted Answer · 2011-04-17 17:33:09Z

2

Up at the top of your "click" handler, stash the this value:

var theButton = this;

Then, in your ".post()" handler:

$(theButton).addClass('vote-up-1');

The problem is that this will not refer to the button when jQuery calls your ".post()" handler. Thus, you save a copy into a local variable, and it'll be there waiting for the handler when the time comes.

answered Apr 17, 2011 at 17:33

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Naveed Ahmad · Accepted Answer · 2011-04-17 17:35:24Z

0

Brother: $(this).addClass('vote-up-1'); // ** the culprit ** is truly the culprit. $(this) is not available in this scope so it's better that you get the handle of the button before doing any ajax. such as:

var btnHnd = $(this); Now you can do the post stuff: $.post('user/?action=ajax', { ...

answered Apr 17, 2011 at 17:35

Naveed Ahmad

3,1751 gold badge17 silver badges18 bronze badges

Comments

Nighil · Accepted Answer · 2011-04-17 17:37:22Z

0

change this

 $(putyourbuttonidhere).addClass('vote-up-1');

answered Apr 17, 2011 at 17:37

Nighil

4,1277 gold badges34 silver badges58 bronze badges

Collectives™ on Stack Overflow

Adding a class to a button in jquery

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related