Windows application issue in array sum

Question

Given an array initialized with numbers, how can I add all of its elements without using LINQ or foreach?

My incomplete code is as follows:

namespace WindowsApplication5
{
   public partial class Form1 : Form
   {
      public Form1()
      {
         InitializeComponent();
      }

      public void Form1_Load(object sender, EventArgs e)
      {
         method1(sum1);
         MessageBox.Show("The Sum Is = " + sum1.ToString(), "Addition",MessageBoxButtons.OK,MessageB…
      }
      int sum1;
      int[] str = new int[4] { 1, 2, 3, 4 }; // i want to add this 4 values and to be printed on a messagebox//

      public int method1(int str)
      {
          sum1 = str;
          return sum1;
      }
   }
}

The output is showing "the sum is = 0", instead of 10.

Thank you.

P.S: I don't want to use LINQ or foreach.

Ahh - how stupid of me - that's why Aliza can't use linq!!!! — Adam Rackis
– Adam Rackis, Commented Apr 19, 2011 at 21:00
I have added my answer below, but just a few comments on your code that should help you in your learning. Method names should be descriptive 'method1' is a poor example. You are using global variables - Google why there are a bad idea. Get into good habits now, they will serve you well for the future. — Darren
– Darren, Commented Apr 19, 2011 at 21:06

Amar Palsapure · Accepted Answer · 2012-02-01 11:47:11Z

3

For a start you have global variables which are bad. Without using LINQ or Foreach as you mentioned, try something like:

//Doesn't have to be a button click...just an example.
private void button1_Click(object sender, EventArgs e)
{
   int[] values = new int[4] { 1, 2, 3, 4 };
   int result = Sum(values);
   MessageBox.Show(result.ToString());
}

int Sum(int[] values)
{
   int sum= 0;
   for (int i = 0; i < values.Length; ++i)
   {
       sum += values[i];
   }
   return sum;
}

edited Feb 1, 2012 at 11:47

Amar Palsapure

9,6561 gold badge29 silver badges46 bronze badges

answered Apr 19, 2011 at 20:58

Darren

1364 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Amar Palsapure · Accepted Answer · 2012-02-01 11:47:51Z

2

The simplest options that don't use foreach or LINQ would be to use either a for loop or recursion. The recursive solution:

int Sum(int[] arr, int index = 0, int current = 0)
{
  if(index == arr.Length)
    return current;
  return Sum(arr, index+1, current+arr[index]);
}

Using a for loop:

int Sum(int[] arr)
{
  int result = 0;
  for(int i = 0; i<arr.Length; i++)
    result+=arr[i];
  return result;
}

edited Feb 1, 2012 at 11:47

Amar Palsapure

9,6561 gold badge29 silver badges46 bronze badges

answered Apr 19, 2011 at 23:14

Michail Smith

673 bronze badges

Comments

Adam Rackis · Accepted Answer · 2011-04-19 20:59:22Z

1

To take the sum of an array, you can simply say: int sum = myArray.Sum();

To do so you need to have: using System.Linq since that's where the Sum extension method is defined.

If you don't have linq, then how about:

private int CalculateSum(int[] arr){
   int total = 0;
   foreach(int i in arr)
      total += i;
   return total;
}

edited Apr 19, 2011 at 20:59

answered Apr 19, 2011 at 20:52

Adam Rackis

83.5k57 gold badges281 silver badges402 bronze badges

5 Comments

Aliza Over a year ago

its not applying, it says that int does not contain a definition for sum

Adam Rackis Over a year ago

Sorry, I just saw your comment that you don't want to use LINQ or foreach. I'm not sure if you're using an older version of .NET without linq, but the only other way I can think of to sum an array is with a for loop

Aliza Over a year ago

it is not working man, Sum(); is not in my context, i am not using LINQ

Aliza Over a year ago

ya if it is done with a for loop then how the code will be? can u post it?

Adam Rackis Over a year ago

Even if you're not using LINQ, there shouldn't be any reason why you can't add a using directive for System.Linq. Are you using .NET 3.5 or later?

Amar Palsapure · Accepted Answer · 2012-02-01 11:48:41Z

1

I'm curious about why you're opposed to a for loop. Could you enlighten us?

Unless I'm missing something, it seems like you've got two options:
1) use an existing method (in this case it would be the .Sum() method, in LINQ), or
2) write a method yourself to compute the sum (that would be the foreach loop)

edited Feb 1, 2012 at 11:48

Amar Palsapure

9,6561 gold badge29 silver badges46 bronze badges

answered Apr 19, 2011 at 21:04

Joe

8305 silver badges15 bronze badges

1 Comment

Adam Rackis Over a year ago

The question said: without a foreach loop - I suspect foreach is covered next week in class :)

Collectives™ on Stack Overflow

Windows application issue in array sum

4 Answers 4

Comments

Comments

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related