syntax error in python shorthand expression

Question

I am using bs4 to scrape a website I have this piece of expression: links = ['https://example.com/' + link['href'] for link in school.findAll('a')]

What I need is to add another condition that if link has href only than append it with links. Here is the normal code.

if link.has_attr('href'):
    //append'

I have tried this but found no success

links = ['https://example.com/' + link['href'] if link.has_attr('href') for link in school.findAll('a')]

['https://example.com/' + link['href'] for link in school.findAll('a') if link.has_attr('href')] — Sraw
– Sraw, Commented Aug 2, 2019 at 6:22

bharatk · Accepted Answer · 2019-08-02 06:32:34Z

1

There is two possible way:

1.

This will return all link tag if the tag has href attribute.

findAll('a',href=True)

2.

['https://example.com/' + link['href'] for link in school.findAll('a') if link.has_attr('href')]

If you are using bs4, better to use find_all() method instead findAll()

answered Aug 2, 2019 at 6:25

bharatk

4,3455 gold badges19 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

QHarr · Accepted Answer · 2019-08-02 06:50:16Z

1

There is another way which is to only return a tags with href via css selector:

links = ['https://example.com/' + link['href'] for link in school.select('a[href]')]

answered Aug 2, 2019 at 6:50

QHarr

84.5k14 gold badges58 silver badges105 bronze badges