Dynamically add key/value array of names into array of objects

Question

I have an array of names. I also have an array of objects. I would like to iterate through the array of objects and also iterate through the the array of names and add the name into the objects. For example, name[0] goes into object[0], and so on.

I have this code:

this.individualSrv.GetDataById(this.org[i].userId).subscribe(data => {
  this.names.push(data.fullname)
  for (var x = 0; x < this.org.length; x++) {
    for (var i in this.names) {
      this.org[x]['name'] = this.names[i]
    }                    
   }                  
})

Right now, the last name in the array is added to each object in the array.

Why are you using two indexes? this.org[x]['name'] = this.names[x] should be enough, the nested for is unnecessary, though you should loop the longest array first. May you share some examples, though? — briosheje
– briosheje, Commented Aug 2, 2019 at 9:36
seems you already are looping through this.org cuz GetDataById(this.org[i].userId), I assume that you will get only one user per id, then why another two loops? you simply can this.org[i].name=data.fullname after this.names.push(data.fullname). — arizafar
– arizafar, Commented Aug 2, 2019 at 9:47

Morphyish · Accepted Answer · 2019-08-02 09:39:33Z

1

You don't need to nest 2 loops to do that. Just make sure that both arrays have the same length.

this.individualSrv.GetDataById(this.org[i].userId).subscribe(data => {
  this.names.push(data.fullname)
  for (var x = 0; x < this.org.length; x++) {
      this.org[x]['name'] = this.names[x]
   }                  
})

answered Aug 2, 2019 at 9:39

Morphyish

4,07210 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

mhfour Over a year ago

thanks so much. i was thinking that different arrays need different iterations

Collectives™ on Stack Overflow

Dynamically add key/value array of names into array of objects

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related