Undefined variable even if it is defined Laravel

Question

So I get this error Undefined variable: games even if my variable is defined in controller:

My Controller:

 public function openingPage($id) {

      $this->getCaseData($id);

      $this->getGames();

      return view('caseopener', ['cases' => $this->data])->with('games',$games);;

    }

    private function getCaseData($id) {
        $items = DB::table('cases')->where('id', $id)->get();
        $data = @$items[0] ? $items[0] : array();
        if(isset($data->items)) {
            $data->items = json_decode($data->items, true);
        }

        $this->data = $data;
    }

   private function getGames() {
      $games = array();
      foreach ($this->data->items as $item) {
          $game = new Game($item);
          $games[] = array(
            'id' => $game->id,
            'name' => $game->name,
            'image' => $game->image,
          );
      }

      return $games;
  }

The problem seems to be from the getGames() function

my blade:

@for ($i = 0; $i < 10; $i++)
                      <div class="item" style="background-image:url({{ $games->image }})">
            </div>
          @endfor

and if needed here is my Model 'Game' which is used in that getGames() function

class Game extends Model
{
  private $id;
  public $data;

  public function __construct($id) {
       parent::__construct();
       $this->id = $id;
       $this->data = $this->getData();
   }

   private function getData() {

       $game = DB::table('products')->where('id', $this->id)->first();

       if(empty($game)) return array();

       return $game;
   }
}

Possible duplicate of "Notice: Undefined variable", "Notice: Undefined index", and "Notice: Undefined offset" using PHP — aynber
– aynber, Commented Aug 5, 2019 at 16:06
You return $games in your getGames function, but never assign it when you call $this->getGames(); — aynber
– aynber, Commented Aug 5, 2019 at 16:07

dparoli · Accepted Answer · 2019-08-05 16:08:50Z

2

You forgot to assign $games in openingPage(), try this:

public function openingPage($id) {

     $this->getCaseData($id);

     $games = $this->getGames();

     return view('caseopener', ['cases' => $this->data])->with('games',$games);;
}

answered Aug 5, 2019 at 16:08

dparoli

9,1911 gold badge34 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Paul Sorrells Over a year ago

I updated it and now I get Trying to get property of non-object. This error is from the view blade now

aynber Over a year ago

Because $games is an array of arrays, not an array of objects.

dparoli Over a year ago

I answered your original question, please accept and upvote if the original error is gone, if you have another problem open a new question.

Paul Sorrells Over a year ago

how can I fix that? can you help me please?

dparoli Over a year ago

Sorry I would like to be helpful but this is not the way it works here at SO, we cannot debug all your code, if you want you can edit your question and add details

Thomas · Accepted Answer · 2019-08-05 16:28:22Z

1

As @dparoli mentioned, you forgot to assign the games to the $games variable.

In addition there's a mistake when outputting the value: $games->image should be $games[$i]['image']. (Access a specific game and get the image value as an array value)

If there is any chance there might be more or less than 10 games in the future I would replace the for loop with foreach:

@foreach($games in $game)
    <div class="item" style="background-image:url({{ $game['image'] }})">
    </div>
@endforeach

answered Aug 5, 2019 at 16:28

Thomas

8,8592 gold badges28 silver badges54 bronze badges

Collectives™ on Stack Overflow

Undefined variable even if it is defined Laravel

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related