Why doesn't my Javascript switch statement work?

Question

I have a switch statement and I must be overlooking something, because I don't see why it wouldn't work.

$('.handles a').click(function() {
    var li = $(this).parent();

    switch ($(li).data('handle')) {
    case 'minimize':
        $('.window', li).hide();
        break;
    }

    return false;
});

Also setup a fiddle @ http://jsfiddle.net/9aHvx/4/ (click on Min)

It should hide the .window div, but it doesn't :(

OMG I suck. You all rock. Nevermind. I == stupid. Going to bed now :P Thanks for pointing out the obvious :) bows his head in shame — PeeHaa
– PeeHaa, Commented Apr 20, 2011 at 22:21

shanethehat · Accepted Answer · 2011-04-20 22:13:45Z

3

this line $('.window', li).hide(); is wrong. if you want to target .window and li, you need to write it like you would for css:

$('.window, li').hide();

Edit: Fiddle http://jsfiddle.net/9aHvx/7/

answered Apr 20, 2011 at 22:13

shanethehat

15.6k11 gold badges59 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Jakob Over a year ago

That does something completly different than what he is asking for.

PeeHaa Over a year ago

Nopez. the li is a var. $('.window', li) means .window in li element

shanethehat Over a year ago

In which case it fails because div.window isn't inside an li.

Jakob Over a year ago

Yes, that is right PeeHaa. But do you really think he wants to hide everything and not just the window? (hm.. on second thought you MIGHT be right, but I think he's just looking for a window to hide the element with the window-class)

shanethehat Over a year ago

I mistook his intention, but either way the li is misplaced.

|

Jakob · Accepted Answer · 2011-04-20 22:18:32Z

2

Using the syntax:

$('.window', li).hide();

means that you search for an element with the class window, starting from the node li. Objects with the window class that are NOT descendants of li will NOT be matched.

In your markup, this is exactly the case. You should skip the second parameter all together. Or, you could rearrange your markup (but that is probably not what you want).

Go for:

$('.window').hide();

EDIT: This is if you want to hide the window-element only. If you want to hide the li's as well, then goo for shanethehat's solution.

answered Apr 20, 2011 at 22:18

Jakob

24.5k9 gold badges48 silver badges58 bronze badges

Comments

user · Accepted Answer · 2011-04-20 22:17:10Z

1

The .window div is not inside the li element, so you don't have to pass the li variable as parameter:

$('.window').hide();

answered Apr 20, 2011 at 22:17

user

6,86719 gold badges61 silver badges87 bronze badges

Comments

Aleadam · Accepted Answer · 2011-04-20 22:19:03Z

1

http://jsfiddle.net/9aHvx/13/

Use $('.window').hide(); instead, because there are no <li> inside <div class="window">

answered Apr 20, 2011 at 22:19

Aleadam

40.4k9 gold badges88 silver badges108 bronze badges

Comments

Dirty-flow · Accepted Answer · 2014-03-11 11:13:52Z

1

Your selector is off

$('.handles a').click(function() {
    var li = $(this).parent();
    var x = $(li).data('handle');
    switch (x) {
    case 'minimize':
        alert(x);
        $('.window').hide();
        break;
    }

    return false;
});

jsFiddle link

edited Mar 11, 2014 at 11:13

Dirty-flow

2,30011 gold badges30 silver badges49 bronze badges

answered Apr 20, 2011 at 22:15

secretAgentB

1,2894 gold badges21 silver badges37 bronze badges

2 Comments

PeeHaa Over a year ago

Hmmmmm.... So I can't use the jquery selector in the switch statement? That's strange or isn't it? Why is that, anyone?

secretAgentB Over a year ago

I mean the $('.window', li) part should have been $('.window, li') sorry if I'm not being clear. I just stored the value into a variable so I can debug it easily using alert.

PeeHaa · Accepted Answer · 2011-04-20 22:29:21Z

0

K sorry I wasted your time.

I just made a major boo boo! :P

  $('.handles a').click(function() {

    var snippet = $(this).parents('.snippet');

    switch($(this).parent().data('handle')) {
      case 'minimize':
        $('.window', snippet).hide();
        break;
    }

    return false;
  });

Thanks all :)

answered Apr 20, 2011 at 22:29

PeeHaa

73.1k60 gold badges195 silver badges264 bronze badges

Collectives™ on Stack Overflow

Why doesn't my Javascript switch statement work?

6 Answers 6

7 Comments

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

7 Comments

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related