check input validation [Javascript]

Question

I was woking on a problem and got stuck and how I should validate a given string input. Here is the original question

I think my approach is ok but I'm stuck on what to do now.

here is my attempt so far:

const solution =(S)=>{
 let validParams = {
   '--count': '--count',
   '--name': '--name',
   '--help': '--help'
 }

let strToTest;
for(k of validParams){

  switch (S.includes(k)) {
    case '--help':
    return 1
    case '--count':
     strToTest = parseInt(S.replace(/--count/g,''))
      return countValidator(strToTest);
    case '--name':
    strToTest = S.replace(/--count/g,'')
      return nameValidator(strToTest);
    default:
      return 1
  }
}
}

const countValidator = (num) =>{
  if(num > 10 && num < 100){
    return 0
  }
}

const nameValidator = (str) =>{
  if(str.length > 3 && str.length < 10){
    return 0
  }
}

Here the test cases I saw as well:

solution('--count g') // -1
solution('-help name') // -1
solution('--name SOME_NAME --COUNT 10') // 0
solution('--count 44') // 0

validators are always invoked without arguments, how are they supposed to work? — briosheje
– briosheje, Commented Aug 12, 2019 at 15:32
The parameter to case shouldn't be a boolean expression. It's a string that will be compared with S. Use if/else if/else to perform other kinds of tests. — Barmar
– Barmar, Commented Aug 12, 2019 at 15:33
@briosheje I completely forgot to add the arguments. I just included it. — bruce
– bruce, Commented Aug 12, 2019 at 15:46
@Barmar I switched the switch case around, still not returning what I expect and im a little confused on why you suggested the if/else. can you explain — bruce
– bruce, Commented Aug 12, 2019 at 15:47

Barmar · Accepted Answer · 2019-08-12 16:05:09Z

1

You need to split the input into words first, then test the array elements.

You can't return the result of a validator immediately if it succeeds, since you have to keep testing other parameters.

function solution(S) {
  let params = S.split(/\s+/).map(str => str.toLowerCase()); // \s+ matches any amount of whitespace between parameters
  let result = 0;
  if (params.includes('--help')) {
    result = 1;
  }
  for (let i = 0; i < params.length; i++) {
    switch (params[i]) {
      case "--help":
        break;
      case "--count":
        i++;
        if (i > params.length) {
          result--;
          return result;
        }
        let n = parseInt(params[i]);
        if (isNaN(n) || n < 10 || n > 100) {
          result--;
          return result;
        }
        break;
      case "--name":
        i++;
        if (i > params.length) {
          result--;
          return result;
        }
        let str = params[i];
        if (str.length < 3 || str.length > 10) {
          result--;
          return result;
        }
        break;
      default:
        result--;
        return result;
    }
  }
  return result;
}
console.log(solution('--count g')); // -1
console.log(solution('-help name')); // -1
console.log(solution('--name SOME_NAME --COUNT 10')); // 0
console.log(solution('--count 44')) // 0

edited Aug 12, 2019 at 16:05

answered Aug 12, 2019 at 15:47

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

bruce Over a year ago

I see what you mean now. The only think that isn't really clear at the moment is the regex you included when you declared the params variable.

Barmar Over a year ago

It matches any amount of whitespace between parameters.

bruce Over a year ago

okay, thank you now it makes more sense to me and I understand why splitting the string is needed first

Collectives™ on Stack Overflow

check input validation [Javascript]

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related