Foreach in JS array

Question

I am beginner in JS. I have this sample array:

{"record-164": {"tomany": true, "fileName": "164"},"record-165": {"tomany": true, "fileName": "165"}}

and code JS:

var data = JSON.parse(json);

if (data["tomany"] == true && data["fileName"] !=""){
    var fileName = data["fileName"];
    $.ajax({
        headers: {
            'X-CSRF-TOKEN': $('meta[name="_token"]').attr('content')
        },
        cache: false,
        type: 'POST',
        url: '{{ route('deleteDJS') }}?id=' + fileName + '&type={{ $pageType }}',
        data: {filename: fileName, id: fileName, type: '{{ $pageType }}'},
        success: function (data) {
            console.log("Delete file" +fileName);
            refreshFileList();
            //updatePhotoList();
        },
        error: function (e) {
            console.log(e);
        }
    });
    alert('Limit plików został przekroczony. Możesz dodać maksymalnie: ');
    return;
}

The above code does not work correctly. I would like the js script to delete it when the file has the parameter: tomany == true.

The delete function works correctly.

Problem is with file name and tomany parameters - I have many files - not one to delete/parse.

How can I repair this?

"I have this sample array" ...that's not an array, it's an object. The difference is important. — ADyson
– ADyson, Commented Aug 20, 2019 at 10:06
I simply cannot understand what is the question here. The title and the description seem unrelated — vsync
– vsync, Commented Aug 20, 2019 at 10:08
You have to use data["record-164"]["tomany"] instead of data["tomany"] — fiveobjects
– fiveobjects, Commented Aug 20, 2019 at 10:09
Anyway, data["tomany"] will fail because the object doesn't have a property tomany. The properties of the top-level object are record-164 and record-165. Each of those then contains another object which has a "tomany" property. You will need to read the data from the correct sub-property. From your description it's not clear if you are trying to read from a specific record only, or if you want to read all of them one after another and delete them all. — ADyson
– ADyson, Commented Aug 20, 2019 at 10:09
I want to check all objects in turn. If any object has tomany = true - then I want to delete it. — goslscs
– goslscs, Commented Aug 20, 2019 at 10:11

Arup Rakshit · Accepted Answer · 2019-08-20 10:13:04Z

1

Use for in to iterate your object as below.

for(var item in data){

  if (data[item]["tomany"] == true && data[item]["fileName"] !=""){
    // perform your task here 
  }

}

edited Aug 20, 2019 at 10:13

Arup Rakshit

119k30 gold badges270 silver badges328 bronze badges

answered Aug 20, 2019 at 10:11

Mir Nawaz

3742 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kaushik · Accepted Answer · 2019-08-20 10:11:39Z

1

First that is an object its not array.

You can distinguish object and array using this

starts with { -> object

example

const d = {'name':'your-name', 'age':23};

starts with [ -> array

const d_array = [{'name':'your-name', 'age':23},{'name':'your-name-2', 'age':26}];

You can iterate your object like this and then do the ajax.

const data = {"record-164": {"tomany": true, "fileName": "164"},"record-165": {"tomany": true, "fileName": "165"}}


for(let key in data){
  console.log(data[key]["tomany"]);
  console.log(data[key]["fileName"]);
}

answered Aug 20, 2019 at 10:11

Kaushik

2,0901 gold badge24 silver badges32 bronze badges

Comments

Andy · Accepted Answer · 2019-08-20 12:32:40Z

Instead of iterating over the data and doing an AJAX call if the conditions are met it might be better to split up the code so you're doing one job at a time.

1) Iterate over the object and produce an array of AJAX promises based on the conditions.

2) Use jQuery's $.when to wait until all the calls have been made and then

3) Update the file list based on the results

const data = {"record-164": {"tomany": true, "fileName": "164"}, "record-165": {"tomany": true, "fileName": "165"}};

function doFetch(filename) {
  return $.ajax({ ... });
}

function getPromises(data) {
  return Object.keys(data).reduce((acc, obj) => {
    const { tomany, fileName } = obj;
    if (tomany && filename){
      const promise = doFetch(filename);
      return acc.concat(promise);
    }
    return acc;
  }, []);
}

$.when.apply(null, getPromises()).then(result => {
  updateFilenames(result);
});

fiveobjects · Accepted Answer · 2019-08-20 10:17:17Z

Iterate the data object and access tomany field of each object to decide on deletion.

   Object.keys(data).forEach(key => {
        console.log(key);
        if (data[key]["tomany"] == true && data[key]["fileName"] != "") {
            var fileName = data[key]["fileName"];
            console.log("Going to delete file: " + fileName);
        }
   });

Here is your modified code. I have commented out the actual API call part to make it executable.

var json = '{ "record-164": { "tomany": true, "fileName": "164" }, "record-165": { "tomany": true, "fileName": "165" } }';
var data = JSON.parse(json);
function doSomething() {
    Object.keys(data).forEach(key => {
        console.log(key);
        if (data[key]["tomany"] == true && data[key]["fileName"] != "") {
            var fileName = data[key]["fileName"];
            console.log("Going to delete file: " + fileName);
            // $.ajax({
            //     headers: {
            //         'X-CSRF-TOKEN': $('meta[name="_token"]').attr('content')
            //     },
            //     cache: false,
            //     type: 'POST',
            //     url: '{{ route("deleteDJS") }}?id=' + fileName + '&type={{ $pageType }}',
            //     data: { filename: fileName, id: fileName, type: '{{ $pageType }}' },
            //     success: function (data) {
            //         console.log("Delete file" + fileName);
            //         refreshFileList();
            //         //updatePhotoList();
            //     },
            //     error: function (e) {
            //         console.log(e);
            //     }
            // });
            console.log('Limit plików został przekroczony. Możesz dodać maksymalnie: ');
            return;
        }
    });
}

doSomething();

TRIKONINFOSYSTEMS · Accepted Answer · 2019-08-20 10:23:46Z

-1

You can do something like this.

var json = {
  "record-164": {
    "tomany": true,
    "fileName": "164"
  },
  "record-165": {
    "tomany": true,
    "fileName": "165"
  }
}

function cleanJson(data, keys) {
  for (let i in data) {
    if (keys.includes(i)){ 
      delete data[i];
      //Do you file delete here
    }else if (typeof data[i] === 'object') cleanJson(data[i], keys)
  }
}
cleanJson(json, 'tomany')
console.log(json)

edited Aug 20, 2019 at 10:23

answered Aug 20, 2019 at 10:18

TRIKONINFOSYSTEMS

6401 gold badge8 silver badges20 bronze badges

Collectives™ on Stack Overflow

Foreach in JS array

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related