PHP foreach only returns first [0] of nested array

Question

I have an object like below, with arrays nested in each other. I use foreach loops to loop through the first and second level of the arrays.

array (
   'totalHits' => 500,
   'total'     => 845,
   'hits' =>
   array (
       0 => array (
              'url' => 'www.someurl.com',
              'id'  => '11',
       ),
       1 => array (
              'url' => 'www.differenturl.com',
              'id'  => '22',
       ),
 );

I am trying to get keys and values from all the arrays nested in 'hits', but I only get the first one, hits[0]. What am I missing?

<?php 
	if($_SERVER['REQUEST_METHOD']=='POST'){
		
		$keywords		= $_POST['pixa_keyword'];    		
		$api_key 		= "my_hidden_api_key";
		$url 			= "https://pixabay.com/api/?key=".$api_key."&safesearch=true&q=".$keywords;
		$json			= file_get_contents($url);
		
		
	}
	
	
?>

<body>
	

<form action="#" method="post">
	<input name="pixa_keyword" id="cms_pixaSearchKeywords2" type="text" value="">		
	<input name="submit_pixa_search" id="cms_pixaSearchBtn2" type="submit" value="search">
</form>


<div id="cms_displayPixaResults"></div>
	
<?php 
	
	$pixa_feedback=[];
	
	
	if($_SERVER['REQUEST_METHOD']=="POST"){
		$pixa_feedback = json_decode($json);
	}
	

	foreach($pixa_feedback as $inner){
		// check type
		if(is_array($inner)){
			// iterate through nested array
			$i = 0;
			foreach ($inner[$i] as $key => $value){      
				echo $key . ": " . $value . " <br>";
				$i++;
			}
		}
	}
	
	
?>

Nick · Accepted Answer · 2019-09-05 23:30:44Z

1

Your counter variable isn't doing anything as your foreach will only iterate over $inner[0] and then stop. You need to add a third level of iteration:

foreach($pixa_feedback as $inner){
    // check type
    if(is_array($inner)){
        // iterate through nested array
        foreach ($inner as $values){
            foreach ($values as $key => $value) {
                echo $key . ": " . $value . " <br>";
            }
        }
    }
}

Output:

url: www.someurl.com <br>id: 11 <br>
url: www.differenturl.com <br>id: 22 <br>

Demo on 3v4l.org

answered Sep 5, 2019 at 23:30

Nick

147k23 gold badges67 silver badges106 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Melvin Over a year ago

Thanks so much - this works! This was the most specific answer thus I will flag this as the correct answer!

MalcolmInTheCenter · Accepted Answer · 2019-09-05 23:28:10Z

0

You weren't looping through your array correctly Try this:

$temp = array (
   'totalHits' => 500,
   'total'     => 845,
   'hits' =>
   array (
       0 => array (
              'url' => 'www.someurl.com',
              'id'  => '11',
       ),
       1 => array (
              'url' => 'www.differenturl.com',
              'id'  => '22',
       ),
 ));

foreach($temp["hits"] as $inner_arr){
     echo $inner_arr["url"];
     echo $inner_arr["id"];
}

answered Sep 5, 2019 at 23:28

MalcolmInTheCenter

1,6556 gold badges31 silver badges49 bronze badges

Comments

Islingre · Accepted Answer · 2019-09-05 23:29:32Z

0

In a foreach you do not need a counter variable. The loop-body will run for every item in the first "argument". Thus the inner loop (during the outer-loop's 3rd iteration) iterates over array ('url' => 'www.someurl.com', 'id' => '11') and finishes afterwards.

answered Sep 5, 2019 at 23:29

Islingre

2,37810 silver badges20 bronze badges

Collectives™ on Stack Overflow

PHP foreach only returns first [0] of nested array

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related