Compare 2 variables with 2 variables in Javascript

Question

I just started studying Javascript and I'm trying to create a mini-game. I want to get the vocation of a character comparing if his health skill and attack skill are bigger than magic and speed, then he's a knight. But what I'm trying is not working.

if (hp1 && at1 > mg1 && sp1){
    document.querySelector('.badgesContainer .knight').style.display = 'block'
}
else{
    document.querySelector('.badgesContainer .druid').style.display = 'none'
    document.querySelector('.badgesContainer .knight').style.display = 'none'
    document.querySelector('.badgesContainer .paladin').style.display = 'none'
    document.querySelector('.badgesContainer .sorcerer').style.display = 'none'  
}

This hp1 && at1 > mg1 && sp1 actually means just: if hp is truthy and at1 is bigger than mg1 and sp1 is truthy. — Gerardo Furtado
– Gerardo Furtado, Commented Sep 17, 2019 at 23:58
What you probably want is: hp1 > mg1 && hp1 > sp1 && at1 > mg1 && at1 > sp1. — Gerardo Furtado
– Gerardo Furtado, Commented Sep 17, 2019 at 23:59
I'd add a vocation property. It makes things easier down the road. — ps2goat
– ps2goat, Commented Sep 18, 2019 at 0:01
It depends on the variable types. If they're numbers, you can do (based on your literal requirement): if ((hp1 + at1) > (mg1 + sp1)), which simply adds hp and attack, then checks if that's greater than the total for magic and speed. — ps2goat
– ps2goat, Commented Sep 18, 2019 at 0:04

Vincent Dante · Accepted Answer · 2019-09-18 00:08:28Z

2

You can add the hp1 and at1 then compare it to mg1 and sp1

if ( (hp1 + at1) > (mg1 + sp1)){
    document.querySelector('.badgesContainer .knight').style.display = 'block'
}
else{
    document.querySelector('.badgesContainer .druid').style.display = 'none'
    document.querySelector('.badgesContainer .knight').style.display = 'none'
    document.querySelector('.badgesContainer .paladin').style.display = 'none'
    document.querySelector('.badgesContainer .sorcerer').style.display = 'none'  
}

answered Sep 18, 2019 at 0:08

Vincent Dante

1661 silver badge7 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Compare 2 variables with 2 variables in Javascript

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related