Python function that will find and count vowels in a given string [duplicate]

Question

I am trying to write a code with python that will find and count the number of vowels in any given string. My function prints out 0 vowels no matter what. Any tips?

txt = input("Type text: ").lower()

def findVowels():
    global txt
    vowels = 0
    for letter in txt:
        if letter == 'aeiouy':
            vowels += 1
    return vowels


print(findVowels())

Number of vowels = 0 no matter what

This is may not be code related but technically, "y" is not a vowel. — CodeRed
– CodeRed, Commented Oct 2, 2019 at 9:00
@CodeRed In English, "y" is considered as a vowel when it is not the first letter of syllable within a word. I.e. it is a consonant in the word "yup", but a vowel in the word "symbol". — James
– James, Commented Oct 2, 2019 at 9:02
I'd love to explain but this is not the best platform for that. Good day sir! — CodeRed
– CodeRed, Commented Oct 2, 2019 at 9:06
In my language, Norwegian "y" is a vowel so that's why it's in there — mikkelven
– mikkelven, Commented Oct 11, 2019 at 13:29

zipa · Accepted Answer · 2019-10-02 09:00:49Z

4

Try like this:

def findVowels(txt):
    return sum(1 for t in txt if t in 'aeiouy')

edited Oct 2, 2019 at 9:00

answered Oct 2, 2019 at 8:59

zipa

28k6 gold badges45 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user2390182 Over a year ago

Double def and you can even do: return sum(t in 'aeiouy' for t in txt)

creyD Over a year ago

Why couldn't you?

zipa Over a year ago

@schwobaseggl Thanks for the heads up, and you can, but tends to be slower do to conversion of bool to int.

ruohola · Accepted Answer · 2019-10-02 09:20:59Z

2

You are checking if the letter is equal to the entire string 'aeiouy'. Instead check if letter is in the string.

if letter in 'aeiouy':

Also, you can avoid using global variable by passing the input text to the function.

txt = input("Type text: ").lower()

def findVowels(txt):
    vowels = 0
    for letter in txt:
        if letter in 'aeiouy':
            vowels += 1
    return vowels


print(findVowels(txt))

edited Oct 2, 2019 at 9:20

ruohola

24.8k7 gold badges76 silver badges118 bronze badges

answered Oct 2, 2019 at 8:59

James

37k4 gold badges54 silver badges79 bronze badges

Collectives™ on Stack Overflow

Python function that will find and count vowels in a given string [duplicate]

2 Answers 2

3 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Linked

Related