MS SQL doesn't return data in NodeJS

Question

I created config file for database like below:

module.exports.connection = {
  sqlserver: {
    user: 'user_name',
    password: 'password',
    server: 'servername\\instancename',
    database: 'database_name',
    port: 1433,
  },
};

I have a simple table in database:

I'm trying get a data from table above like below:

const sql = require('mssql');
const config = require('../config/connection');

sql.connect(config.connection.sqlserver).then((pool) => pool.request().query('select type from dbo.category')).then((result) => {
  console.log(result);
}).catch((err) => {
  console.log(err);
});

sql.close();

Unfortunately I doesn't see anything in console and I don't have any error so I can't find what's wrong. I tried also:

sql.connect(config.connection.sqlserver).then((pool) => pool.request().query('select type from dbo.category')).catch((err) => {
    console.log(err);
  }).then((result) => {
    console.log(result);
  }).catch((err) => {
    console.log(err);
  });
  sql.close();

I used https://www.npmjs.com/package/mssql#promises. I'm trying to do it on my nodeJs server. Any ideas?

try change your query like this select * from categoryand check what it returns, and also add some string to console log to see if then or catch worked. Like this 'console.log('then() handled. Result: ', result);' — Julia Shestakova
– Julia Shestakova, Commented Oct 2, 2019 at 14:50
ok, are you checked that this code was called? Add console before and after this code, and also you can try test only connection first sql.connect(config.connection.sqlserver).then( result => console.log('connected!')).catch((err) => console.log('some error')); — Julia Shestakova
– Julia Shestakova, Commented Oct 2, 2019 at 15:03
oh, yeah. It happens b/c sql.close() calling before you finish your query. Just place it into last then, and also into catch (to close connection if error). To close it after you'll done. Or use async/await instead of then/catch. — Julia Shestakova
– Julia Shestakova, Commented Oct 3, 2019 at 8:57

Robert Daraż · Accepted Answer · 2019-10-03 14:11:30Z

1

I resolved my problem. Thanks for Julia Shestakova suggestions. My query function looks like this:

const sql = require('mssql');
const config = require('./config/connection');
module.exports = {
  query(query) {
    return sql.connect(config.connection.sqlserver).then(() => sql.query(query)).then((result) => {
      sql.close();
      return result.recordset;
    }).catch((err) => console.log(err));
  },
};

I'm returning Promise so I can use then to presentation my data when I'm calling query function on a server.

answered Oct 3, 2019 at 14:11

Robert Daraż

3324 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

MS SQL doesn't return data in NodeJS

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related