JavaScript: string.replace() does not work, what is the problem?

Question

I've tried everything, but my code doesn't work. I don't know why.

Here is it:

var table = $("#cpTableBody").html();  
$("#cpTableBody").html('');

var tmpContent = "";
for (i=0; i<cpData.length; i++) {
  var tmpTable = table;
  tmpTable.replace(/{firstname}/g, cpData[i].contact_person.firstname);
  tmpTable.replace(/{lastname}/g, cpData[i].contact_person.lastname);
  tmpContent += tmpTable;
}

$("#cpTableBody").html(tmpContent);

table never changes so var tmpTable = table; in the loop seems to be pointless reassignment, and that further implies that {firstname} and {lastname} are going to be replaced in the first loop iteration and all other iterations will do nothing. Am I missing something? — Stephen P
– Stephen P, Commented Apr 29, 2011 at 18:59

pixelbobby · Accepted Answer · 2011-04-29 18:59:33Z

6

easy answer... you're not setting tmpTable = tmpTable.replace... like so:

var tmpContent = ""; 
for (i=0; i<cpData.length; i++) {   
    var tmpTable = table;   
    tmpTable = tmpTable.replace(/firstname/g, cpData[i].contact_person.firstname + "");   
    tmpTable = tmpTable.replace(/{lastname}/g, cpData[i].contact_person.lastname + "");   
    tmpContent += tmpTable; 
}

edited Apr 29, 2011 at 18:59

answered Apr 29, 2011 at 18:53

pixelbobby

4,4305 gold badges33 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

silent Over a year ago

Thank you so much :) 8 hours of coding make me a headache ;)

pixelbobby Over a year ago

no problem. don't forget to mark this as the answer by clicking the checkmark on this post :) It will also help you when you ask more questions on this site because your "answer rate" will be 100% and encourage people to post.

Collectives™ on Stack Overflow

JavaScript: string.replace() does not work, what is the problem?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related