Refactor IF-Else nested code with switch statement in Swift

Question

I'm trying to improve my swift coding.

I have a fully working if-else nested function which I believe could be better optimised with a Switch Statement. Can anybody advise the correct way to do this code-refactoring ?

Here's my working code:

    if firstButton.frame.contains(location) {
        UIView.animate(withDuration: 0.4) {
            self.firstButton.transform = CGAffineTransform(scaleX: -1, y: 1)
            self.firstButton.alpha = 0
                 if self.tapCount == 0 {self.placeholderText1.textWithAnimation(text: self.firstButton.text!, duration: 0.3);self.tapCount += 1}
            else if self.tapCount == 1 {self.placeholderText2.textWithAnimation(text: self.firstButton.text!, duration: 0.3);self.tapCount += 1}
            else if self.tapCount == 2 {self.placeholderText3.textWithAnimation(text: self.firstButton.text!, duration: 0.3);self.tapCount += 1}
            else if self.tapCount == 3 {self.placeholderText4.textWithAnimation(text: self.firstButton.text!, duration: 0.3);self.tapCount += 1}
            else if self.tapCount == 4 {self.placeholderText5.textWithAnimation(text: self.firstButton.text!, duration: 0.3);self.lastLetterTapped()}
        }
    } else
        if secondButton.frame.contains(location) {
            UIView.animate(withDuration: 0.4) {
                self.secondButton.transform = CGAffineTransform(scaleX: -1, y: 1)
                self.secondButton.alpha = 0
                     if self.tapCount == 0 {self.placeholderText1.textWithAnimation(text: self.secondButton.text!, duration: 0.3);self.tapCount += 1}
                else if self.tapCount == 1 {self.placeholderText2.textWithAnimation(text: self.secondButton.text!, duration: 0.3);self.tapCount += 1}
                else if self.tapCount == 2 {self.placeholderText3.textWithAnimation(text: self.secondButton.text!, duration: 0.3);self.tapCount += 1}
                else if self.tapCount == 3 {self.placeholderText4.textWithAnimation(text: self.secondButton.text!, duration: 0.3);self.tapCount += 1}
                else if self.tapCount == 4 {self.placeholderText5.textWithAnimation(text: self.secondButton.text!, duration: 0.3);self.lastLetterTapped()}
            }
    } else
            if thirdButton.frame.contains(location) {
                UIView.animate(withDuration: 0.4) {
                    self.thirdButton.transform = CGAffineTransform(scaleX: -1, y: 1)
                    self.thirdButton.alpha = 0
                         if self.tapCount == 0 {self.placeholderText1.textWithAnimation(text: self.thirdButton.text!, duration: 0.3);self.tapCount += 1}
                    else if self.tapCount == 1 {self.placeholderText2.textWithAnimation(text: self.thirdButton.text!, duration: 0.3);self.tapCount += 1}
                    else if self.tapCount == 2 {self.placeholderText3.textWithAnimation(text: self.thirdButton.text!, duration: 0.3);self.tapCount += 1}
                    else if self.tapCount == 3 {self.placeholderText4.textWithAnimation(text: self.thirdButton.text!, duration: 0.3);self.tapCount += 1}
                    else if self.tapCount == 4 {self.placeholderText5.textWithAnimation(text: self.thirdButton.text!, duration: 0.3);self.lastLetterTapped()}
                }
            } else
                if fourthButton.frame.contains(location) {
                    UIView.animate(withDuration: 0.4) {
                        self.fourthButton.transform = CGAffineTransform(scaleX: -1, y: 1)
                        self.fourthButton.alpha = 0
                             if self.tapCount == 0 {self.placeholderText1.textWithAnimation(text: self.fourthButton.text!, duration: 0.3);self.tapCount += 1}
                        else if self.tapCount == 1 {self.placeholderText2.textWithAnimation(text: self.fourthButton.text!, duration: 0.3);self.tapCount += 1}
                        else if self.tapCount == 2 {self.placeholderText3.textWithAnimation(text: self.fourthButton.text!, duration: 0.3);self.tapCount += 1}
                        else if self.tapCount == 3 {self.placeholderText4.textWithAnimation(text: self.fourthButton.text!, duration: 0.3);self.tapCount += 1}
                        else if self.tapCount == 4 {self.placeholderText5.textWithAnimation(text: self.fourthButton.text!, duration: 0.3);self.lastLetterTapped()}
                    }
                } else
                    if fifthButton.frame.contains(location) {
                        UIView.animate(withDuration: 0.4) {
                            self.fifthButton.transform = CGAffineTransform(scaleX: -1, y: 1)
                            self.fifthButton.alpha = 0
                                 if self.tapCount == 0 {self.placeholderText1.textWithAnimation(text: self.fifthButton.text!, duration: 0.3);self.tapCount += 1}
                            else if self.tapCount == 1 {self.placeholderText2.textWithAnimation(text: self.fifthButton.text!, duration: 0.3);self.tapCount += 1}
                            else if self.tapCount == 2 {self.placeholderText3.textWithAnimation(text: self.fifthButton.text!, duration: 0.3);self.tapCount += 1}
                            else if self.tapCount == 3 {self.placeholderText4.textWithAnimation(text: self.fifthButton.text!, duration: 0.3);self.tapCount += 1}
                            else if self.tapCount == 4 {self.placeholderText5.textWithAnimation(text: self.fifthButton.text!, duration: 0.3);self.lastLetterTapped()}
                        }

    }

Working code should be posted on Code Review

Sweeper
– Sweeper

2019-10-14 08:50:18 +00:00
Commented Oct 14, 2019 at 8:50 — Sweeper
– Sweeper, Commented Oct 14, 2019 at 8:50
What's the type of self.placeholderText1?

PGDev
– PGDev

2019-10-14 09:27:31 +00:00
Commented Oct 14, 2019 at 9:27 — PGDev
– PGDev, Commented Oct 14, 2019 at 9:27
placeholderTextn are labels

Alex
– Alex

2019-10-14 09:29:03 +00:00
Commented Oct 14, 2019 at 9:29 — Alex
– Alex, Commented Oct 14, 2019 at 9:29

InKwon Devik Kim · Accepted Answer · 2019-10-14 12:16:51Z

2

That is not optimized code, but like follow code, combine duplicate action code as function

func anything (button: UIButton) {
    UIView.animate(withDuration: 0.4) {[weak self] in
    guard let `self` = self else { return }

    self.button.transform = CGAffineTransform(scaleX: -1, y: 1)
    self.button.alpha = 0

    switch self.tapCount {
      case 0: 
        self.placeholderText1.textWithAnimation(text: button.text!, duration: 0.3)
        self.tapCount += 1
      case 1: 
        self.placeholderText2.textWithAnimation(text: button.text!, duration: 0.3)
        self.tapCount += 1
      case 2: 
        self.placeholderText3.textWithAnimation(text: button.text!, duration: 0.3)
        self.tapCount += 1
      case 3: 
        self.placeholderText4.textWithAnimation(text: button.text!, duration: 0.3)
        self.tapCount += 1
      case 4: 
        self.placeholderText5.textWithAnimation(text: button.text!, duration: 0.3)
        self.lastLetterTapped()
    }
}

// 
guard let foundButton = [
  firstButton, secondButton, thirdButton, fourthButton, fifthButton
].first{ $0.frame.contains(location) } else { return }

anything(button: foundButton)

edited Oct 14, 2019 at 12:16

answered Oct 14, 2019 at 9:09

InKwon Devik Kim

3473 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Pravin Tate Over a year ago

In findButton you can use first function on button array so no need to write again if_else there.

JeremyP Over a year ago

findButton won't compile. You don't handle the case where no button matches.

JeremyP Over a year ago

@PravinTate Like this? [firstButton, secondButton, thirdButton, fourthButton, fifthButton].first{ $0.frame.contains(location) }

Pravin Tate Over a year ago

@JeremyP Perfect. As question on if_else so now we make it more optimised. :D

JeremyP Over a year ago

@InKwonJamesKim guard needs an else. I fixed it for you.

|

PGDev · Accepted Answer · 2019-10-14 09:45:39Z

2

You can rewrite your code to,

if let locationView = [firstButton, secondButton, thirdButton, fourthButton].first(where: {$0.frame.contains(location)}) {
    UIView.animate(withDuration: 0.4) {[weak self] in
        guard let `self` = self else {
            return
        }

        button.transform = CGAffineTransform(scaleX: -1, y: 1)
        button.alpha = 0

        var placeholderText: UITextInput? //change the type to whatever type of placeholderText1 and others
        switch self.tapCount {
        case 0:
            placeholderText = self.placeholderText1
        case 1:
            placeholderText = self.placeholderText2
        case 2:
            placeholderText = self.placeholderText3
        case 3:
            placeholderText = self.placeholderText4
        case 4:
            placeholderText = self.placeholderText5
            self.lastLetterTapped()
        default:
            break
        }
        if let text = placeholderText,  {
            text.textWithAnimation(text: button.text, duration: 0.3)
            if self.tapCount != 4 {
                self.tapCount += 1
            }
        }
    }
}

In the above code,

var placeholderText: UITextInput? //change the type to whatever type of placeholderText1 and others

Replace UITextInput with the type of placeholderText1.

edited Oct 14, 2019 at 9:45

answered Oct 14, 2019 at 9:31

PGDev

24.3k6 gold badges38 silver badges91 bronze badges

2 Comments

Pravin Tate Over a year ago

if let button = [UIView(), UIView(), UIView(), UIView()].filter({ - Here you can use first function for more optimised.

Pravin Tate Over a year ago

I'm saying instead of using filter func you can use first func there.

Collectives™ on Stack Overflow

Refactor IF-Else nested code with switch statement in Swift

2 Answers 2

8 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related