Remove word from string if included in array?

Question

A relatively straight forward issue I think, however I'm having a few issues getting it right.

I've got an array of strings and a sentence. If any of the words in the array appear in the sentence, remove them.

const products = ["premium t-shirt", "t-shirt", "sweatshirt", "baseball tee", "v-neck t-shirt", "long sleeve t-shirt", "raglan baseball tee", "pullover hoodie", "tank top", "zip hoodie",
"hoodie", "shirt", "tee", "tshirt"];

const name = "I'd Rather Be Beekeeping Save The Bees Honey Bee Beehive Zip Hoodie T-Shirt".toLowerCase();
let strippedName;
products.forEach(p => {
    if(name.includes(p)) strippedName = name.replace(p, "");
});

The above removes the word shirt, but not t-shirt. Theres also the issue of it needed to loop around on the strippedName variable rather tan the name.

I'm not sure if theres a better way to do this though?

It might be caused by capital letters of T-Shirt compared to the t-shirt in the array? — Wilson Sim
– Wilson Sim, Commented Oct 29, 2019 at 16:41
@WilsonSim, name is being made to lowercase .toLowerCase() — K20GH
– K20GH, Commented Oct 29, 2019 at 16:42

Code Maniac · Accepted Answer · 2019-10-29 16:43:46Z

2

You're override strippedName everyti,e with latest replaced value from name string, whereas you need to pass the use last replaced value when using the replace on next value

const products = ["premium t-shirt", "t-shirt", "sweatshirt", "baseball tee", "v-neck t-shirt", "long sleeve t-shirt", "raglan baseball tee", "pullover hoodie", "tank top", "zip hoodie","hoodie", "shirt", "tee", "tshirt"];
const name = "I'd Rather Be Beekeeping Save The Bees Honey Bee Beehive Zip Hoodie T-Shirt".toLowerCase();
let strippedName = name;

products.forEach(p => {
  if (name.includes(p)){
   strippedName = strippedName.replace(p, "");
  }
});

console.log(strippedName)

answered Oct 29, 2019 at 16:43

Code Maniac

37.9k5 gold badges44 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

ziggy wiggy Over a year ago

The order of the items in products will have an impact on its success. For example, if the sentence contains tshirt, the t will currently be left.

Code Maniac Over a year ago

@ziggywiggy yes totally agree with you, not only order but also the submatching words will also be replaced as OP is using regex in original code without any word boundaries so i assume OP isn't much bothered about that so i kept the answer focused on what i see actual problem in code

ziggy wiggy · Accepted Answer · 2019-10-29 16:43:50Z

0

Convert the array to a case insensitive, global regex.

const products = ["premium t-shirt", "t-shirt", "sweatshirt", "baseball tee", "v-neck t-shirt", "long sleeve t-shirt", "raglan baseball tee", "pullover hoodie", "tank top", "zip hoodie",
  "hoodie", "shirt", "tee", "tshirt"
];

const name = "I'd Rather Be Beekeeping Save The Bees Honey Bee Beehive Zip Hoodie T-Shirt";

let strippedName = name.replace(new RegExp(products.join("|"), "gi"), "");

console.log(strippedName);

If any of the products characters are regex special characters, they'll first need to be escaped.

answered Oct 29, 2019 at 16:43

ziggy wiggy

1,0777 silver badges6 bronze badges

Comments

Huỳnh Tuân · Accepted Answer · 2019-10-29 16:57:25Z

0

I think you mean:

const products = ["premium t-shirt", "t-shirt", "sweatshirt", "baseball tee", "v-neck t-shirt", "long sleeve t-shirt", "raglan baseball tee", "pullover hoodie", "tank top", "zip hoodie",
"hoodie", "shirt", "tee", "tshirt"];

var name = "I'd Rather Be Beekeeping Save The Bees Honey Bee Beehive Zip Hoodie T-Shirt".toLowerCase();
let strippedName = name;
products.forEach(p => {
    if(name.includes(p)){
        strippedName = strippedName.replace(p, "");
    } 
});

answered Oct 29, 2019 at 16:57

Huỳnh Tuân

1168 bronze badges

Comments

saidutt · Accepted Answer · 2019-10-29 17:02:19Z

0

const products = ["premium t-shirt", "t-shirt", "sweatshirt", "baseball tee", "v-neck t-shirt", "long sleeve t-shirt", "raglan baseball tee", "pullover hoodie", "tank top", "zip hoodie",
"hoodie", "shirt", "tee", "tshirt"];

const name = "I'd Rather Be Beekeeping Save The Bees Honey Bee Beehive Zip Hoodie T-Shirt".toLowerCase();
let strippedName = name;
products.forEach(p => {
  if(strippedName.includes(p)) {
    strippedName = strippedName.replace(p, "");
  }
});
console.log(strippedName);

answered Oct 29, 2019 at 17:02

saidutt

2891 silver badge7 bronze badges

Comments

saidutt · Accepted Answer · 2019-10-29 16:51:06Z

-1

The includes method is case sensitive. It will consider 'T-shirt' and 't-shirt' differently. You should consider transforming the string to a upper/lower case and then perform your include method.

const products = ["premium t-shirt", "t-shirt", "sweatshirt", "baseball tee", "v-neck t-shirt", "long sleeve t-shirt", "raglan baseball tee", "pullover hoodie", "tank top", "zip hoodie", "hoodie", "shirt", "tee", "tshirt"];

const name = "I'd Rather Be Beekeeping Save The Bees Honey Bee Beehive Zip Hoodie T-Shirt".
const n = name.toUpperCase();
let strippedName;
products.forEach(p => {
    if(n.includes(p.toUpperCase())) strippedName = new.replace(p, "");
});

edited Oct 29, 2019 at 16:51

answered Oct 29, 2019 at 16:46

saidutt

2891 silver badge7 bronze badges

5 Comments

Scott Marcus Over a year ago

The OP is already doing that and since the array values are lower-case, you should use .toLowerCase().

saidutt Over a year ago

My bad, I see that now. But you should also be changing the case in your if block for individual array elements

Scott Marcus Over a year ago

Not needed because all array items are already lower case and the .toLowerCase() call on name returns a new string that is all lower-case. That string is being captured as name and name is what the condition is testing.

Scott Marcus Over a year ago

Also, it's a bad idea to name anything new.

Scott Marcus Over a year ago

The real problem is that the OP is checking name upon each loop iteration, but setting the replaced string into strippedName.

Collectives™ on Stack Overflow

Remove word from string if included in array?

5 Answers 5

2 Comments

Comments

Comments

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

Comments

Comments

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related