How to call external javascript file in PHP?

Question

I am learning how to call external javascript files in my PHP code. I got some codes from the internet and tried it but its not working. Can somebody pls give me some advice or explain to me this. I am not a programmer but I am studying how to program and just started learning that's why I have difficulty understanding some concepts.

I have here the codes, PHP File and JS file. They are in the same folder.

Here are the codes:

index.php

<html>
<head>
 <script language="JavaScript" src="exer_1.js"></script>
</head>
<body>
 <form name="myform">
  <input type="text" id="input_1" name="input_1" /><br />
  <input type="text" id="input_2" name="input_2" /><br />
  <input type="submit" value="Check!" onclick="javascript:parseTest() return false;" />
 </form>
</body>
</html>

exer_1.js

function parseTest() {
 var elem_1 = document.getElementById('input_1');
 var elem_2 = document.getElementById('input_2');

 var inp_1 = elem_1.value;
 var inp_2 = elem_2.value;

 if (inp_1 == "" && inp_2 == "") {
  alert("You need to enter integers!!!");
  elem_1.focus();
 } else if (inp_1 == ""){
  alert("You need to enter Integer 1!!!");
  elem_1.focus();
 } else if (inp_2 == ""){
  alert("You need to enter Integer 2!!!");
  elem_2.focus();;
 } else {
  if (!parseInt(inp_1) || !parseInt(inp_2)) alert ("Enter Integers only!!!");
  else {
   alert("Correct Inputs!!!");
  }
 } 
}

as you said you were new to all this, have you ever heard of Firebug plugin for firefox? Its seriously a developers best friend! (If you are using Chrome, it has a similar tool) — neolaser
– neolaser, Commented May 3, 2011 at 1:45

Phil · Accepted Answer · 2011-05-03 01:50:17Z

13

<script language="JavaScript" src="exer_1.js"></script>

The language attribute is deprecated, use type instead

<script type="text/javascript" src="exer_1.js"></script>

The correct syntax for inline event binding is

<input type="submit" value="Check!" onclick="parseTest(); return false;" />

You may want to consider moving the event handler to the form's submit event. Your function could then return false on error or true on success, which can then be used to determine whether the form submission continues or not, eg

<form onsubmit="return parseTest()">

edited May 3, 2011 at 1:50

answered May 3, 2011 at 1:44

Phil

166k25 gold badges265 silver badges269 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Gem Over a year ago

Can you pls help me with my code, actually i am using datatables.net/examples/styling/bootstrap4 my code : justpaste.it/5ytqq @Phil

Ibu · Accepted Answer · 2011-05-03 01:47:06Z

1

You have not really specified what is not working but i am noticing something in your code.

<html>
<head>
 <script language="JavaScript" src="exer_1.js"></script>
</head>
<body>
 <form name="myform">
  <input type="text" id="input_1" name="input_1" /><br />
  <input type="text" id="input_2" name="input_2" /><br />
 <!-- The following will cause an error -->
  <input type="submit" value="Check!" onclick="javascript:parseTest() return false;" />

<!-- instead use this -->
<input type="submit" value="Check!" onclick="javascript:parseTest(); return false;" />
 </form>
</body>
</html>

semicolon error

answered May 3, 2011 at 1:47

Ibu

44k14 gold badges82 silver badges109 bronze badges

Comments

Dietpixel · Accepted Answer · 2011-05-03 02:06:15Z

1

I would look into JQuery for a nice javascript framework. Instead of putting javascript code on the button's "onclick" event, with jquery you could do something like:

$('#submit').click(function() {
  // whatever code you want to run when submit is clicked.
  alert('Submit clicked');
}

answered May 3, 2011 at 2:06

Dietpixel

10.2k11 gold badges31 silver badges33 bronze badges

1 Comment

Phil Over a year ago

You can do this without jQuery too, it just takes more effort getting it to work cross-browser

Phil · Accepted Answer · 2020-02-03 20:25:25Z

1

<script type="text/javascript" src="exer_1.js"></script>

edited Feb 3, 2020 at 20:25

Phil

166k25 gold badges265 silver badges269 bronze badges

answered May 3, 2011 at 1:46

Zero

7381 gold badge7 silver badges16 bronze badges

2 Comments

Ibu Over a year ago

how is it possible to post a blank answer?

Phil Over a year ago

@Ibrahim Check the answer source, it contains HTML

Collectives™ on Stack Overflow

How to call external javascript file in PHP?

4 Answers 4

1 Comment

Comments

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related