Problem with fetching data from mysql into email

Question

I'm using this code to send data from mysql into email :

$sql = "SELECT * FROM orders ORDER BY id";
$result = mysqli_query($conn, $sql);

if (mysqli_num_rows($result) > 0) 
{
    // append data of each row to $msg.
    while($row = mysqli_fetch_assoc($result)) 
    {
        $body .= " <style>
        table{width:100%}
            table, th, td {
                border: 1px solid black;
                border-collapse: collapse;
            }
            th, td {
                padding: 5px;
                text-align: left;
            }
        </style> ". 
        "<table>".
        "<tr> <th> name </th>
              <th>last name</th>
              <th>email</th>
        </tr>".

        "<tr>".
            "<td>". $row["col1"]. "</td>".
            "<td>" . $row["col2"]. "</td>".
            "<td>" . $row["col3"]. "</td>".
        "</tr>". 
    "</table>" ;      
  }

  $body = wordwrap($body,70);
  mail($to_email, $subject, $body, $headers);
} 
else 
{
  echo "0 results";
}

mysqli_close($conn);

?>

It works fine but the only problem that I'm getting multi tables but I want to display all the rows in single table.

Can anyone tell me what I'm doing wrong or how to fix it ?

delboy1978uk · Accepted Answer · 2019-11-06 12:33:48Z

3

Move the table HTML tags outside of your loop:

<table>
    <thead>
      <th>Header</th>
    </thead>
    <tbody>
        <?php //put your loop here ?>
    </tbody>
</table>

answered Nov 6, 2019 at 12:33

delboy1978uk

12.4k2 gold badges25 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pardeep Kumar · Accepted Answer · 2019-11-06 15:31:17Z

0

Assign HTML table tag to body variable outside for loop.

 $sql = "SELECT * FROM orders ORDER BY id";

    $result = mysqli_query($conn, $sql);

    if (mysqli_num_rows($result) > 0) {

    $body= " <style>
    table{width:100%}
    table, th, td {
    border: 1px solid black;
    border-collapse: collapse;
    }
    th, td {
    padding: 5px;
    text-align: left;
    }
    </style> <table>";
   $body.="<tr>
      <th>name</th>
      <th>last name</th>
      <th>email</th>
     </tr>";
    while($row = mysqli_fetch_assoc($result)) {
      $body.=
      "<tr>".
        "<td>". $row["col1"]. "</td>".
        "<td>" . $row["col2"]. "</td>".
        "<td>" . $row["col3"]. "</td>" .
      "</tr>";
      }
    $body.="</table>" ;
      $body = wordwrap($body,70);
      mail($to_email, $subject, $body, $headers);
    } else {
      echo "0 results";
    }
    mysqli_close($conn);

edited Nov 6, 2019 at 15:31

answered Nov 6, 2019 at 12:41

Pardeep Kumar

831 silver badge9 bronze badges

5 Comments

Aksen P Over a year ago

You've made a mistake in while loop.

Max Over a year ago

yes there is a mistake in this code but thank you anyway :)

jeroen Over a year ago

This is a very poor answer. Instead of just posting code with Use this instead you should explain why this would solve the OP's problem.

Pardeep Kumar Over a year ago

I just added the explanation. hope that will help future readers.

jeroen Over a year ago

I think that explanation belongs to another answer / question :-)

Collectives™ on Stack Overflow

Problem with fetching data from mysql into email

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related